Uh oh!
There was an error while loading. Please reload this page.
Added prototype for a map, just drop it into a public folder on a web… - #2
Added prototype for a map, just drop it into a public folder on a web…#2Famicoman wants to merge 1 commit into
Conversation
| <head> | ||
| <meta charset="utf-8"/> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=no"/> | ||
| <title>Map / Philly Mesh</title> |
There was a problem hiding this comment.
@garrying Is there a good way to group these deployment-specific parts in a configuration file?
There was a problem hiding this comment.
There are ways, but I think choosing a good one depends more on whatever like idiom we want to follow. We already work with jekyll, yaml, liquid for our web stuff so maybe continue in that vein?
Based on our current web deployment I could see either being feasible(?):
- using jekyll and _config.yml, and having to generate the site before deploy
- using grunt with grunt-liquid to have the grunt config handle titles, etc...
| <div class="title-container"> | ||
| </div> | ||
| </nav> | ||
| <!--<div class="content bg-white"> |
| @@ -0,0 +1,37 @@ | |||
| { | |||
There was a problem hiding this comment.
@dcwalk Github renders this with OSM, so we can potentially do this with OSM instead, or make gmaps vs. osm a config?
| @@ -0,0 +1,37 @@ | |||
| { | |||
| "type": "FeatureCollection", | |||
| "features": [ | |||
There was a problem hiding this comment.
I guess we can write our node-list schema based on this?
There was a problem hiding this comment.
Yeah, for a start! tho I think we might eventually want to take advantage of nested key-values for grouping types of info.
Regardless, we can quickly iterate
| @@ -0,0 +1,7304 @@ | |||
| { | |||
| var panoramas = event.feature.f.panoramas | ||
| if (panoramas) { | ||
| content += "<p class='pv0 mv0 near-black fw4 tl'>View from this location:</p>" | ||
| for (var i = 0; i < panoramas.length; i++) { |
There was a problem hiding this comment.
Do you want this code in the monitoring? This is for loading in panos
| } | ||
| </script> | ||
| <script src="https://maps.googleapis.com/maps/api/js?key=AIzaSyBNClp7oJsw-eleEoR3-PQKV23tpeW-FpE&libraries=visualization&callback=initMap" |
There was a problem hiding this comment.
I'd be up for working with a different library like leaflet (http://leafletjs.com/examples/geojson/) for some of this mapping work, we can work with a wider array of basemaps (not just google) if so.
| <title>Map / Philly Mesh</title> | ||
| <link rel="stylesheet" href="main2.css"/> | ||
| <link rel="stylesheet" href="style.css"/> | ||
| <link rel="stylesheet" href="tachyons.min.css"/> |
There was a problem hiding this comment.
Is there a way to refactor some of this style stuff? I think the main2 has normalize and a grid system in it, and tachyons is included seperately.
I think maybe we could gut most of this, go with one framework/toolkit and minimally define css needed on top (and keep normalize?) @garrying this is all you I got nothing else here.
Never worked with tachyons but it looks neat
dcwalk
left a comment
There was a problem hiding this comment.
I left some comments throughout. Is there something you want me to help with here? per below?
I mentioned in a comment that I think it'd be nice to maybe use leaflet etc... to make it a bit easier to use a range of basemaps (incl. OSM tiles).
Anyway, cool stuff :)
dcwalk
commented
Apr 27, 2017
Wanted to pick up this thread! Where are we at with this map? Trying to understand how it related to @Pedro-on-a-bike 's https://github.com/Pedro-on-a-bike/TOMeshNodeMap/ cc @garrying |
Famicoman
commented
May 4, 2017
I was under the impression @Pedro-on-a-bike was developing the de facto version at this point. |
dcwalk
commented
May 19, 2017
Okay! Does that mean we are good to close this PR? I'll try and get Pedro's map into this repo...? |
… server