Uh oh!
There was an error while loading. Please reload this page.
Zero-Storage II: The Lost Years - #17
Conversation
There was a problem hiding this comment.
Can we change the auth = api.authenticate_by_user_name("username@yourservice.com", "<terminal identifier>") line (line 57) to use the user_name and requester_terminal_id variables as well? Doublecheck me, but it should turn into the following:
auth = api.authenticate_by_user_name(user_name, requester_terminal_id)
smholloway
commented
Dec 3, 2013
Lookin' good! Thank you for the updates. |
* develop:
* develop: Fix some perl-specific readme verbiage
There was a problem hiding this comment.
Do we need to include these in the install_requires section of setup.py? I think that's how Pip decides what packages the library relies on.
smholloway
commented
Dec 5, 2013
I approve after the |
trdarr
commented
Dec 10, 2013
Our only direct dependency is |
Zero-Storage II: The Lost Years 👍
This pull request brings to life @smholloway's feedback on PR #16.
Edit: This pull request replaces python-oauth2 and it's gross
/(http|url)lib\d?/cohorts with the excellent Requests library. It also brings in nose for running tests and coverage, which says that this pull request improves test coverage from ~85% to 100%.Try it yourself:
nosetests --with-coverage --cover-package=toopher