Skip to content
This repository was archived by the owner on Oct 2, 2023. It is now read-only.

Zero-Storage II: The Lost Years - #17

Merged
smholloway merged 22 commits into
developfrom
feature/zero-storage
Dec 10, 2013
Merged

Zero-Storage II: The Lost Years#17
smholloway merged 22 commits into
developfrom
feature/zero-storage

Conversation

@trdarr

Copy link
Copy Markdown
Contributor

This pull request brings to life @smholloway's feedback on PR #16.

Edit: This pull request replaces python-oauth2 and it's gross /(http|url)lib\d?/ cohorts with the excellent Requests library. It also brings in nose for running tests and coverage, which says that this pull request improves test coverage from ~85% to 100%.

Try it yourself: nosetests --with-coverage --cover-package=toopher

Comment threadREADME.md

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the auth = api.authenticate_by_user_name("username@yourservice.com", "<terminal identifier>") line (line 57) to use the user_name and requester_terminal_id variables as well? Doublecheck me, but it should turn into the following:

auth = api.authenticate_by_user_name(user_name, requester_terminal_id)

@smholloway

Copy link
Copy Markdown
Member

Lookin' good! Thank you for the updates.

Comment threadrequirements.txt

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to include these in the install_requires section of setup.py? I think that's how Pip decides what packages the library relies on.

@smholloway

Copy link
Copy Markdown
Member

I approve after the setup.py changes are made.

@trdarr

Copy link
Copy Markdown
ContributorAuthor

Our only direct dependency is requests-oauthlib>=0.4.0; requests-oauthlib 0.4.0 itself depends on (from its setup.py) oauthlib>=0.4.2 and requests>=2.0.0.

smholloway added a commit that referenced this pull request Dec 10, 2013
@smholloway
smholloway merged commit 7e064fe into developDec 10, 2013
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@trdarr@smholloway