Fixed Incorrect Null Check - #72
Merged
Merged
Conversation
Fixed null check to check styleToUse instead of styledText.
…encies-for-harfbuzz-and-skiasharp Add Linux Dependencies for HarfBuzz and SkiaSharp
Vercidium
commented
Apr 15, 2023
Contributor
+1, I also had to fix this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
== WHAT ==
Modified null check in ReplaceText to check the styleToUse variable.
== WHY ==
This previous commit added ad-hoc styling:
beb262e
The null check added inadvertently checks "styledText" which was just created instead of checking the "styleToUse" variable before attempting to apply it.