Skip to content

Fix compile - #3

Merged
torrentg merged 1 commit into
torrentg:mainfrom
372046933:fix_compile
Apr 26, 2024
Merged

Fix compile#3
torrentg merged 1 commit into
torrentg:mainfrom
372046933:fix_compile

Conversation

@372046933

Copy link
Copy Markdown
Contributor

Before:

➜ cqueue git:(main) make tests
c++ -g -std=c++20 -Wall -Wextra -Wpedantic -Wconversion -Wsign-conversion -Wnull-dereference -Weffc++ -o cqueue-tests cqueue-tests.cpp
In file included from cqueue-tests.cpp:6:
./cqueue.hpp:586:11: error: missing 'typename' prior to dependent type name 'gto::cqueue<T, Allocator>::value_type'
constexpr gto::cqueue<T, Allocator>::value_type gto::cqueue<T, Allocator>::pop_front() {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
typename ./cqueue.hpp:599:11: error: missing 'typename' prior to dependent type name 'gto::cqueue<T, Allocator>::value_type'
constexpr gto::cqueue<T, Allocator>::value_type gto::cqueue<T, Allocator>::pop_back() {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
typename 2 errors generated.
make: *** [tests] Error 1

After:

➜ cqueue git:(main) ✗ make tests
c++ -g -std=c++20 -Wall -Wextra -Wpedantic -Wconversion -Wsign-conversion -Wnull-dereference -Weffc++ -o cqueue-tests cqueue-tests.cpp
./cqueue-tests
===============================================================================
All tests passed (592 assertions in 1 test case)

@torrentg

Copy link
Copy Markdown
Owner

Thank you for your contribution.

@torrentg
torrentg merged commit 5332e64 into torrentg:mainApr 26, 2024
@372046933
372046933 deleted the fix_compile branch April 26, 2024 06:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@372046933@torrentg