docs(shutdown): revalidate task inventory - #2168
Merged
josecelano merged 5 commits intoSep 8, 2026
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The updated long-lived task inventory frontmatter links issue specs by file path instead of stable issue #NNNN references, which conflicts with the documented semantic-links convention.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the shutdown-process documentation to reflect the post-#1586 implementation reality, revalidating the production task ownership inventory and recording concrete SIGTERM shutdown evidence to close issue #1588.
Changes:
- Replaces the placeholder #1588 verification notes with implementation-time inventory evidence and manual SIGTERM observations.
- Updates the #1588 issue spec to reflect completed acceptance criteria and to point at the verification record instead of planning-time assertions.
- Refactors the shutdown task inventory into a verified overview table plus detailed supporting records, including configuration-dependent cardinality and remaining roadmap gaps.
File summaries
| File | Description |
|---|---|
| docs/issues/open/1588-review-shutdown-process-for-all-tasks-jobs/verification.md | Adds implementation-time validation evidence, gap mapping, and SIGTERM verification notes. |
| docs/issues/open/1588-review-shutdown-process-for-all-tasks-jobs/ISSUE.md | Updates the issue spec timestamps and marks acceptance criteria complete with updated references. |
| docs/features/shutdown-process/task-inventory.md | Converts the inventory from draft/planning to verified/implementation-time with an overview table and detailed evidence. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
josecelano
force-pushed
the
1588-review-shutdown-process
branch
from
September 8, 2026 10:19
6c08c0e to
39e264e
Compare
Member
Author
|
ACK 39e264e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revalidates the production shutdown task inventory after #1586 adopted direct
JoinSetsupervision.Closes #1588
Validation
linter allgit diff --checkTORRUST_GIT_HOOKS_LOG_DIR=.tmp ./contrib/dev-tools/git/hooks/pre-commit.sh