Skip to content

docs(shutdown): revalidate task inventory - #2168

Merged
josecelano merged 5 commits into
torrust:developfrom
josecelano:1588-review-shutdown-process
Sep 8, 2026
Merged

josecelano merged 5 commits into
torrust:developfrom
josecelano:1588-review-shutdown-process

Conversation

@josecelano

Copy link
Copy Markdown
Member

Summary

Revalidates the production shutdown task inventory after #1586 adopted direct JoinSet supervision.

  • Separates direct supervisor components, the narrow legacy periodic-job registry, component-owned children, detached controllers, and framework-owned request work.
  • Records the persistent completed-statistics listener and configuration-dependent task cardinality.
  • Captures direct-binary SIGTERM evidence: cooperative component shutdown, closed listeners, expected legacy-job deadline aborts, and process exit.
  • Maps the remaining gaps to the existing Overhaul: Tracker Shutdown #1488 roadmap without changing runtime behavior or adding a new migration slice.
  • Refactors the inventory into a concise overview table with detailed supporting records.

Closes #1588

Validation

  • linter all
  • git diff --check
  • TORRUST_GIT_HOOKS_LOG_DIR=.tmp ./contrib/dev-tools/git/hooks/pre-commit.sh
  • Pre-push checks: nightly format and workspace check, documentation build, and full test suite
  • Direct tracker-binary SIGTERM scenario

Copilot AI lite review requested due to automatic review settings September 8, 2026 09:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The updated long-lived task inventory frontmatter links issue specs by file path instead of stable issue #NNNN references, which conflicts with the documented semantic-links convention.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the shutdown-process documentation to reflect the post-#1586 implementation reality, revalidating the production task ownership inventory and recording concrete SIGTERM shutdown evidence to close issue #1588.

Changes:

  • Replaces the placeholder #1588 verification notes with implementation-time inventory evidence and manual SIGTERM observations.
  • Updates the #1588 issue spec to reflect completed acceptance criteria and to point at the verification record instead of planning-time assertions.
  • Refactors the shutdown task inventory into a verified overview table plus detailed supporting records, including configuration-dependent cardinality and remaining roadmap gaps.
File summaries
File Description
docs/issues/open/1588-review-shutdown-process-for-all-tasks-jobs/verification.md Adds implementation-time validation evidence, gap mapping, and SIGTERM verification notes.
docs/issues/open/1588-review-shutdown-process-for-all-tasks-jobs/ISSUE.md Updates the issue spec timestamps and marks acceptance criteria complete with updated references.
docs/features/shutdown-process/task-inventory.md Converts the inventory from draft/planning to verified/implementation-time with an overview table and detailed evidence.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/features/shutdown-process/task-inventory.md Outdated
@josecelano
josecelano force-pushed the 1588-review-shutdown-process branch from 6c08c0e to 39e264e Compare September 8, 2026 10:19
@josecelano josecelano self-assigned this Sep 8, 2026
@josecelano

Copy link
Copy Markdown
Member Author

ACK 39e264e

@josecelano
josecelano merged commit 2e1f2b9 into torrust:develop Sep 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review shutdown process for all tasks/jobs

2 participants