Skip to content

docs(issues): publish SI-4 torrent cleanup specification - #2171

Merged
josecelano merged 3 commits into
torrust:developfrom
josecelano:1488-si-4-migrate-torrent-cleanup-spec
Sep 8, 2026
Merged

josecelano merged 3 commits into
torrust:developfrom
josecelano:1488-si-4-migrate-torrent-cleanup-spec

Conversation

@josecelano

Copy link
Copy Markdown
Member

Summary

Publishes the approved specification for #2169, SI-4 in the #1488 shutdown roadmap.

  • Replaces the outdated pre-spawned JoinHandle proposal with an unspawned, token-aware cleanup runner directly owned by JobManager::spawn.
  • Defines explicit normal outcomes for cancellation and weak-manager expiry.
  • Requires deterministic lifecycle and named-supervisor-outcome tests.
  • Adds direct-binary SIGTERM verification and a functional inactive-peer cleanup scenario through the REST API.
  • Requires a separately committed reusable manual cleanup verification skill after the manual scenario establishes the exact procedure.

Related to #2169

Validation

  • linter all
  • git diff --check
  • Mandatory pre-commit checks
  • Pre-push checks: nightly format and workspace checks, documentation build, and full test suite

Copilot AI lite review requested due to automatic review settings September 8, 2026 11:47
@josecelano josecelano self-assigned this Sep 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

Publishes the approved SI-4 specification for migrating torrent cleanup to CancellationToken, moving it from a draft into the EPIC roadmap as an open, tracked issue (#2169).

Changes:

  • Adds a new open issue spec for SI-4 with design, plan, and verification requirements.
  • Updates the EPIC #1488 roadmap to point SI-4 to the new open issue (#2169).
  • Removes the outdated SI-4 draft specification.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File Description
docs/issues/open/2169-1488-si-4-migrate-torrent-cleanup/ISSUE.md New approved SI-4 spec detailing design, ownership invariants, acceptance criteria, and verification.
docs/issues/open/1488-overhaul-tracker-shutdown/ISSUE.md Updates EPIC roadmap entry to reference the new open SI-4 issue instead of the draft.
docs/issues/drafts/1488-si-4-migrate-torrent-cleanup/ISSUE.md Removes the superseded draft SI-4 spec.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/issues/open/2169-1488-si-4-migrate-torrent-cleanup/ISSUE.md Outdated
Comment thread docs/issues/open/2169-1488-si-4-migrate-torrent-cleanup/ISSUE.md
Comment thread docs/issues/open/2169-1488-si-4-migrate-torrent-cleanup/ISSUE.md
josecelano added a commit to josecelano/torrust-tracker that referenced this pull request Sep 8, 2026
josecelano added a commit to josecelano/torrust-tracker that referenced this pull request Sep 8, 2026
@josecelano
josecelano force-pushed the 1488-si-4-migrate-torrent-cleanup-spec branch from 2690f58 to 8554c10 Compare September 8, 2026 15:10
josecelano added a commit to josecelano/torrust-tracker that referenced this pull request Sep 8, 2026
@josecelano
josecelano force-pushed the 1488-si-4-migrate-torrent-cleanup-spec branch from 8554c10 to 7607498 Compare September 8, 2026 15:48
@josecelano
josecelano force-pushed the 1488-si-4-migrate-torrent-cleanup-spec branch from 7607498 to 1cacd68 Compare September 8, 2026 15:55
@josecelano

Copy link
Copy Markdown
Member Author

ACK 1cacd68

@josecelano
josecelano merged commit e4db63d into torrust:develop Sep 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants