-
Notifications
You must be signed in to change notification settings - Fork 57
feat(configuration): [#2151] add tracker config path argument #2178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
josecelano
merged 44 commits into
torrust:develop
from
josecelano:2151-add-tracker-config-path-argument
Sep 9, 2026
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
f5a36c6
test(configuration): cover source selection baseline for #2151
josecelano 3160266
refactor(configuration): add explicit file source for #2151
josecelano 0e336ef
feat(tracker): add explicit configuration path argument
josecelano b5b597f
test(configuration): preserve explicit source semantics
josecelano 480dd55
test(lifecycle): cover CLI configuration isolation
josecelano e8a8624
docs(configuration): document explicit CLI path
josecelano 13353d9
test(tracker): verify CLI configuration failures
josecelano 5fac191
docs(issues): preserve #2151 manual verifier
josecelano 2d142e5
docs(issues): rename #2151 CLI verifier
josecelano ed1f1c2
docs(issues): plan Rust coverage for #2151
josecelano d4bf500
test(integration): extract native tracker fixture
josecelano ff006bc
docs(issues): refine #2151 Rust test plan
josecelano e4dc4b2
test(integration): configure native tracker sources
josecelano 1609f92
test(configuration): verify CLI source precedence
josecelano a109f18
test(configuration): cover CLI override precedence
josecelano 705f003
test(configuration): group CLI source contracts
josecelano 264693d
test(configuration): cover invalid CLI sources
josecelano 8244a68
refactor(test): clarify failed tracker startup
josecelano 2583253
test(configuration): cover unreadable CLI source
josecelano aa029ac
test(configuration): simplify invalid CLI source contracts
josecelano 61ae484
docs(testing): require Rust for tracked test code
josecelano 763b09e
docs(issues): plan verification-type guidance for AI agents
josecelano 36f77f6
docs(testing): define automatic, manual, and disposable verification
josecelano 7ddf16a
docs(configuration): remove disposable Python verifier
josecelano 6288a3c
docs(configuration): record config path verification evidence
josecelano e82ccca
docs(issues): format verification records
josecelano feb5385
style(configuration): group standard imports
josecelano 8e9c0b6
refactor(configuration): clarify explicit source loading
josecelano 957ed39
fix(configuration): address CLI path review findings
josecelano d7bd7ba
fix(test): reap failed tracker start without runtime
josecelano 547bf87
docs(review): add PR review feedback workflow
josecelano 0dbce8b
docs(review): record PR 2178 feedback responses
josecelano 8b3927c
fix(test): bound no-runtime tracker reaping
josecelano aeb3c53
docs(review): complete PR 2178 feedback audit
josecelano a33fdaf
docs(review): record PR 2178 final feedback outcomes
josecelano 3174a6c
docs(review): correct PR 2178 audit chronology
josecelano 78f4cb5
docs(review): add PR 2178 Copilot audit
josecelano df6ccf2
docs(review): finalize PR 2178 feedback audit
josecelano 67feff3
docs(review): correct PR 2178 feedback identifier
josecelano 09d1de6
docs(skills): harden PR feedback thread discovery
josecelano 635ff5a
docs(review): finalize PR 2178 feedback workflow
josecelano 7f313b4
docs(review): correct PR 2178 review history
josecelano 1954882
docs(review): record PR 2178 review outcomes
josecelano 44f634a
docs(review): correct PR 2178 audit timestamp
josecelano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 changes: 92 additions & 0 deletions
92
.github/skills/dev/pr-reviews/process-pr-review-feedback/SKILL.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| --- | ||
| name: process-pr-review-feedback | ||
| description: Process pull-request reviews that may contain multiple independent findings from maintainers, collaborators, or agents acting for them. Use when asked to address reviewer feedback, maintainer PR comments, contributor review summaries, or non-Copilot suggestions. | ||
| metadata: | ||
| author: torrust | ||
| version: "1.0" | ||
| semantic-links: | ||
| related-artifacts: | ||
| - docs/pr-review-feedback/README.md | ||
| - docs/templates/PR-REVIEW-FEEDBACK-TEMPLATE.md | ||
| - .github/skills/dev/pr-reviews/fetch-review-threads/SKILL.md | ||
| - .github/skills/dev/pr-reviews/resolve-review-threads/SKILL.md | ||
| --- | ||
|
|
||
| # Processing PR Review Feedback | ||
|
|
||
| Use this workflow for review feedback from one or more maintainers, | ||
| collaborators, or agents acting for them. Use `process-copilot-suggestions` for | ||
| Copilot-generated review threads instead. | ||
|
|
||
| ## Model | ||
|
|
||
| A submitted **review** and an inline **review thread** are different GitHub | ||
| resources: | ||
|
|
||
| - A review has a numeric review ID, state, body, reviewed commit, and URL. Its | ||
| body may contain multiple findings. GitHub has no resolved state for it. | ||
| - An inline review thread has a GraphQL node ID and can be replied to and | ||
| resolved. A reviewer can create these just as Copilot can. | ||
|
|
||
| Create `docs/pr-review-feedback/pr-<PR_NUMBER>-review-feedback.md` from | ||
| `docs/templates/PR-REVIEW-FEEDBACK-TEMPLATE.md`. Treat its review-response | ||
| state as the durable completion status for a review-level summary. | ||
|
|
||
| ## Procedure | ||
|
|
||
| 1. **Fetch reviews and threads.** Query submitted reviews and inline comments | ||
| by review ID. Fetch all review threads separately, including their IDs, | ||
| author, paths, bodies, and resolved state. The GraphQL thread query is the | ||
| authority: the REST per-review `comments` endpoint can under-report inline | ||
| comments. Do not assume review-comment IDs are thread IDs. | ||
| 2. **Create the audit record.** Add one row per review. Decompose each review | ||
| body and inline comment into one row per independent finding, with a decision | ||
| of `ACTION`, `NO_ACTION`, or `FOLLOW_UP`. | ||
| 3. **Implement each action independently.** For every `ACTION`, make the | ||
| smallest correct change, run relevant validation, and create a separate GPG | ||
| signed Conventional Commit. Do not combine feature fixes with this workflow's | ||
| docs, template, or audit records. | ||
| 4. **Handle inline suggestions.** After the relevant action/no-action decision | ||
| is complete, reply directly on each inline thread. Record the reply URL, | ||
| then resolve the thread using `resolve-review-threads`. Do not resolve before | ||
| replying. | ||
| 5. **Reply to the review summary.** Once all findings from one submitted review | ||
| are done or explicitly deferred, post one consolidated PR conversation | ||
| comment. Include the review ID, each finding's outcome, associated commit, | ||
| validation, and any follow-up. Store that comment URL in the review row. | ||
| 6. **Update progressively.** Update the audit record immediately after each | ||
| commit, PR reply, or resolution. Preserve the historical GitHub review state | ||
| (including `DISMISSED`) and record the current disposition in the audit | ||
| fields. | ||
| 7. **Complete.** Verify every finding status and every inline-thread state from | ||
| the current PR. Commit the workflow/audit documentation separately with a | ||
| signed `docs(review): ...` commit. | ||
|
|
||
| ## GitHub CLI Queries | ||
|
|
||
| Fetch an individual review and its review-specific inline comments: | ||
|
|
||
| ```bash | ||
| gh api repos/torrust/torrust-tracker/pulls/<PR_NUMBER>/reviews/<REVIEW_ID> | ||
| gh api repos/torrust/torrust-tracker/pulls/<PR_NUMBER>/reviews/<REVIEW_ID>/comments?per_page=100 | ||
| ``` | ||
|
|
||
| Fetch all review threads with GraphQL before resolving inline feedback. Use the | ||
| repository `fetch-review-threads` skill for the supported scripts and query | ||
| shape. | ||
|
|
||
| Post a consolidated response as a PR conversation comment: | ||
|
|
||
| ```bash | ||
| gh pr comment <PR_NUMBER> --repo torrust/torrust-tracker --body-file <FILE> | ||
| ``` | ||
|
|
||
| ## Completion Checklist | ||
|
|
||
| - [ ] Reviews and their inline comments fetched by review ID | ||
| - [ ] Audit record has one row per review and one row per independent finding | ||
| - [ ] Each action validated and committed independently | ||
| - [ ] Each inline thread replied to and resolved, with reply URL recorded | ||
| - [ ] Each review summary has one consolidated PR response, with URL recorded | ||
| - [ ] Historical review states and current audit statuses are both recorded | ||
| - [ ] Workflow/audit documentation committed separately from product fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| --- | ||
| semantic-links: | ||
| skill-links: | ||
| - process-copilot-suggestions | ||
| related-artifacts: | ||
| - docs/templates/COPILOT-SUGGESTIONS-TEMPLATE.md | ||
| - .github/skills/dev/pr-reviews/process-copilot-suggestions/SKILL.md | ||
| --- | ||
|
|
||
| <!-- cspell:disable --> | ||
|
|
||
| # PR #2178 Copilot Suggestions Tracking | ||
|
|
||
| Source: Copilot PR review threads for [PR #2178](https://github.com/torrust/torrust-tracker/pull/2178). | ||
|
|
||
| ## Processing Log | ||
|
|
||
| - 2026-09-09 09:00 UTC - Created this audit for the two Copilot threads that were previously handled inline. Both were resolved before this record was added; their decision, fix, and reply URLs were verified from the current PR thread state. | ||
|
|
||
| ## Suggestions | ||
|
|
||
| | # | Thread ID | Path | URL | Suggestion Summary | Decision | Reply URL | Status | Thread State | | ||
| | --- | ----------------------- | ----------------------------------- | ------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------- | ---------------------------------------------------------------------- | ------------------------------------------------------------------------------------ | ------ | ------------ | | ||
| | 1 | `PRRT_kwDOGp2yqc6gYHrC` | `packages/configuration/src/lib.rs` | [thread](https://github.com/torrust/torrust-tracker/pull/2178#discussion_r3961389301) | Explicit-file log said “extra configuration,” implying additive source selection. | `ACTION`: renamed it to “base configuration” in `8e9c0b68`. | [reply](https://github.com/torrust/torrust-tracker/pull/2178#discussion_r3965743966) | `DONE` | `RESOLVED` | | ||
| | 2 | `PRRT_kwDOGp2yqc6gYHrU` | `packages/configuration/src/lib.rs` | [thread](https://github.com/torrust/torrust-tracker/pull/2178#discussion_r3961389339) | Explicit-file reader accepted `&PathBuf` rather than the more general `&Path`. | `ACTION`: accepts `&Path` and owns paths only in errors in `8e9c0b68`. | [reply](https://github.com/torrust/torrust-tracker/pull/2178#discussion_r3965744330) | `DONE` | `RESOLVED` | | ||
|
|
||
| ## Notes | ||
|
|
||
| - Commit `8e9c0b68` passed configuration tests, focused Clippy, formatting, and the required pre-commit gate before the threads were resolved. | ||
| - This late record corrects the missing audit reference identified by PR review feedback; it does not claim the original thread handling occurred after this file was created. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.