chore(deps): [#2234] update torrust-server-lib lifecycle API - #2236
josecelano wants to merge 9 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2236 +/- ##
========================================
Coverage 85.39% 85.40%
========================================
Files 353 353
Lines 31315 31321 +6
Branches 31315 31321 +6
========================================
+ Hits 26743 26751 +8
+ Misses 4190 4188 -2
Partials 382 382 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved documentation metadata issues and a missing timeout for the cancellation contract test remain.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates tracker dependencies to torrust-server-lib 0.3.0 and adds cancellation API contract coverage while leaving legacy shutdown consumers unchanged.
Changes:
- Updates manifests and
Cargo.lock. - Adds an
axum-servercancellation contract test. - Records release, verification, and review evidence; removes superseded drafts.
File summaries
| File | Description |
|---|---|
packages/udp-server/Cargo.toml |
Updates the server library dependency. |
packages/axum-server/src/signals.rs |
Adds cancellation API contract coverage. |
packages/axum-server/Cargo.toml |
Updates the server library dependency. |
packages/axum-rest-api-server/Cargo.toml |
Updates the server library dependency. |
packages/axum-http-server/Cargo.toml |
Updates the server library dependency. |
packages/axum-health-check-api-server/Cargo.toml |
Updates the server library dependency. |
docs/pr-reviews/pr-2236-review.md |
Records the PR review evidence. |
docs/issues/open/2234-1488-si-2-remove-global-shutdown-signal/manual-verification-evidence.md |
Records manual verification evidence. |
docs/issues/open/2234-1488-si-2-remove-global-shutdown-signal/ISSUE.md |
Adds the promoted issue specification. |
docs/issues/open/2234-1488-si-2-remove-global-shutdown-signal/agent-review-reports.md |
Records completion review evidence. |
docs/issues/open/1488-overhaul-tracker-shutdown/ISSUE.md |
Updates shutdown roadmap linkage. |
docs/issues/drafts/1488-si-2-remove-global-shutdown-signal/verification.md |
Removes the superseded verification document. |
docs/issues/drafts/1488-si-2-remove-global-shutdown-signal/ISSUE.md |
Removes the superseded draft issue. |
Cargo.toml |
Updates the workspace dependency. |
Cargo.lock |
Resolves torrust-server-lib 0.3.0. |
Review details
Suppressed comments (5)
docs/issues/open/2234-1488-si-2-remove-global-shutdown-signal/ISSUE.md:11
- The frontmatter timestamp is
09:30, while this document's latest progress entry records2026-09-16 10:50 UTCat line 145. The metadata is therefore stale; update it to the latest documented change time.
last-updated-utc: 2026-09-16 09:30
docs/issues/open/2234-1488-si-2-remove-global-shutdown-signal/ISSUE.md:10
- This spec is being delivered by PR #2236 (as recorded in
docs/pr-reviews/pr-2236-review.md), but its machine-readablerelated-prfield remainsnull. Existing issue specs populate this field once a delivery PR exists, so set it to the current PR number.
related-pr: null
docs/issues/open/2234-1488-si-2-remove-global-shutdown-signal/ISSUE.md:16
- This PR deletes
docs/issues/drafts/1488-si-2-remove-global-shutdown-signal/ISSUE.md, but six remaining draft specs still reference that exact path in their frontmatter (for example SI-11, SI-12, SI-13, SI-14, SI-16, and SI-18), so those links become broken. Update all of those references to the new open path or to the stableissue #2234form before removing the draft path.
- docs/issues/open/1488-overhaul-tracker-shutdown/ISSUE.md
docs/issues/open/2234-1488-si-2-remove-global-shutdown-signal/manual-verification-evidence.md:4
- The canonical manual-verification template and the existing issue-local evidence files use the
issue-specfrontmatter key, notspec-path. Rename this key so tooling and readers following the repository convention can resolve the owning issue specification.
spec-path: docs/issues/open/2234-1488-si-2-remove-global-shutdown-signal/ISSUE.md
packages/axum-server/src/signals.rs:66
- This unbounded await can hang the entire package test run if the released primitive stops completing—the failure mode this contract test is meant to detect. Existing cancellation tests bound awaits with
tokio::time::timeout(for example,packages/swarm-coordination-registry/src/statistics/activity_metrics_updater.rs:140-142); add a short timeout and enable the required Tokio time feature so the test fails deterministically.
wait_task.await.expect("cancellation signal should resolve");
- Files reviewed: 14/15 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
3b54d9a to
99371f4
Compare
Summary
torrust-server-lib0.3.0release, which adds the additivecancellation_signal(CancellationToken)wait primitive.axum-servercontract test that compiles and resolves the released primitive through token cancellation without delivering an OS signal; legacyHaltedconsumers are intentionally unchanged.Scope
Cargo.lockto resolve the crates.io0.3.0release.packages/axum-server/src/signals.rs.Validation
cargo test -p torrust-tracker-axum-server it_should_compile_and_resolve_the_server_lib_cancellation_signal_when_token_is_cancelledcargo test -p torrust-tracker-axum-servercargo machete --with-metadatalinter allcargo test --doc --workspacecargo check --workspaceSIGINT, two same-port directSIGTERMshutdown/restart cycles, and token-only contract test; the complete temporary configuration is retained in tracked issue evidence. Local.tmpconfiguration and logs are not included in this PR.Closes #2234