Skip to content

docs(issues): add numeric conversion review bundle - #2247

Merged
josecelano merged 2 commits into
torrust:developfrom
josecelano:spec/numeric-conversion-review-bundle
Sep 17, 2026
Merged

josecelano merged 2 commits into
torrust:developfrom
josecelano:spec/numeric-conversion-review-bundle

Conversation

@josecelano

Copy link
Copy Markdown
Member

Summary

This PR adds the approved numeric-conversion review bundle to the open issue-spec set:

This is a documentation-only spec PR. It does not implement code changes or begin the numeric-conversion remediation itself.

Related

Related to #2158

Copilot AI lite review requested due to automatic review settings September 16, 2026 17:22
@josecelano josecelano self-assigned this Sep 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

Adds a documentation-only “numeric conversion review” specification bundle (one EPIC + three child task issues) to the open issue-spec set, linking it to the existing numeric conversion inventory from #2158.

Changes:

  • Add EPIC spec #2243 defining review policy, scope, and subissue ownership boundaries.
  • Add child issue specs #2244 (metrics), #2245 (wire/protocol), and #2246 (domain) with plans, acceptance criteria, and verification templates.
  • Link all specs to the #2158 inventory artifacts for reconciliation by inventory ID.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
docs/issues/open/2243-review-numeric-conversion-boundaries/EPIC.md Introduces EPIC #2243 with review policy, subissues, and delivery strategy tied to #2158.
docs/issues/open/2244-2243-review-metric-aggregate-conversions/ISSUE.md Adds the metric-aggregate conversion review child spec with scoped ownership and verification plan.
docs/issues/open/2245-2243-review-numeric-protocol-wire-conversions/ISSUE.md Adds the protocol wire conversion review child spec focused on A156/A171 and retiring crate-level allow.
docs/issues/open/2246-2243-review-domain-numeric-conversions/ISSUE.md Adds the domain conversion review child spec for A099/A123/A129 with invariants + test expectations.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/issues/open/2243-review-numeric-conversion-boundaries/EPIC.md
Comment thread docs/issues/open/2245-2243-review-numeric-protocol-wire-conversions/ISSUE.md Outdated
Comment thread docs/issues/open/2246-2243-review-domain-numeric-conversions/ISSUE.md Outdated
Copilot stopped reviewing on behalf of josecelano due to an error September 16, 2026 17:43
@josecelano
josecelano force-pushed the spec/numeric-conversion-review-bundle branch from a7eb2a6 to d5d31e3 Compare September 17, 2026 08:59
@josecelano

Copy link
Copy Markdown
Member Author

ACK d5d31e3

@josecelano
josecelano merged commit d723ad4 into torrust:develop Sep 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants