fix(ci): exclude dynamic github review anchors - #2255
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2255 +/- ##
===========================================
+ Coverage 85.48% 85.49% +0.01%
===========================================
Files 353 353
Lines 31321 31333 +12
Branches 31321 31333 +12
===========================================
+ Hits 26775 26789 +14
+ Misses 4166 4165 -1
+ Partials 380 379 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Updates the Lychee online-link configuration to ignore dynamic GitHub pull-request review and comment anchors that cannot be reliably validated.
Changes:
- Clarifies the configuration comment to refer to pull-request review anchors.
- Excludes pull-request
issuecommentandpullrequestreviewfragment URLs from checking.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
ACK 5611b2f |
0624e4e docs(issues): address external-link handoff review (Jose Celano) 1844949 docs(issues): relate semantic-link validators to guardrails epic (Jose Celano) d77a779 docs(issues): close external-link triage handoff (Jose Celano) Pull request description: Closes #2185. ## Summary - records the final hosted External Link Check evidence after PR #2255 - preserves the residual Lychee report in the semantic-link EPIC draft folder - marks #2185 acceptance criteria and completion review done - hands Medium, Stack Overflow, FSF, GNU license, and critical unstable external-reference policy questions to the semantic-link EPIC ## Validation - linter markdown - linter cspell - linter lychee - git diff --check - linter all - ./contrib/dev-tools/git/hooks/pre-commit.sh via installed pre-commit hook - pre-push hook ACKs for top commit: josecelano: ACK 0624e4e Tree-SHA512: b39d43ff345a4e61c84e634cdd02dbacba34e654335ad5969eec150c4d64ae7d0a692afc100b780488e549911f73f9cdb39bf0b06dfe5dc78057e5babe35c392
Summary
Exclude dynamic GitHub PR review and issue-comment fragment anchors from the advisory online link check. These anchors are rendered client-side by GitHub and are not stable check targets for Lychee.
Why
The hosted link checker reports "Cannot find fragment" for review/comment anchors such as:
Those fragments are generated dynamically by GitHub; they are not stable static document anchors and should not be treated as stale project links.
Verification