Add PSR-0 classloading for "CRM" - #265
Merged
Merged
Conversation
Contributor
|
When I had looked at this before I needed to make path "." - the empty string didn't work (I don't remember the reason). |
totten
force-pushed
the
master-psr0-crm
branch
from
October 7, 2022 14:22
0c93f2d to
14f8f92
Compare
Owner
Author
|
Aah, thanks. The Pushed update. |
colemanw
added a commit
to colemanw/civix
that referenced
this pull request
Nov 11, 2022
Since totten#265 the `include_path` addition has not been needed except for odd edge-cases where the extension has stuff that's not covered by the autoloader. I'm honestly not sure what those things might be, but best-practice is to use the autoloader and not mess with `include_path`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
info.xmlin new extensions (civix generate:module) and existing extensions (civix upgrade) to declare:Todo: Check test results