Uh oh!
There was an error while loading. Please reload this page.
TOW-1130 - clean up deps to be optional/dev when not needed by core - #126
Merged
Conversation
socksy
requested review from
bradhe, giray123, jo-sm, konstantinoscs and sammutiNovember 3, 2025 17:12
| "openapi-python-client==0.24.3", | ||
| "pre-commit==4.0.1", | ||
| "pyiceberg[sql-sqlite]==0.9.1", | ||
| "tower[iceberg]", |
ContributorAuthor
There was a problem hiding this comment.
hmm well it's needed for tests which are run with the dev group of deps (before this change the transitive deps needed from the other optional deps were in the main deps, but the point of the change was to remove them, so now we need them in the tests).
I just modified the existing import of transitive deps, but looking at it I think these probably should have been in the test group all along, since they're there for the tests (and dev imports all test group deps anyway).
sammuti
approved these changes
Nov 4, 2025
socksyforce-pushed
the
feature/tow-1130-cleanup-python-dependencies
branch
from
November 4, 2025 18:56
b8b5f3c to
9a0cfcbCompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves TOW-1130
Not sure how we ended up with ollama, hugging face and iceberg duplicated in the core dependencies, but we don't need them there, since they already have their own dependency groups.
MCP is only needed for the integration test of the Rust CLI, so absolutely no need to put that in the main dependencies.
Python 3.10 was needed by the MCP library, but it's already there in the dev dependencies next to MCP for that very reason.