Uh oh!
There was an error while loading. Please reload this page.
TOW-1131 - add py.typed to python sdk - #127
Merged
Merged
Conversation
socksy
requested review from
bradhe, giray123, jo-sm, konstantinoscs and sammutiNovember 3, 2025 17:17
konstantinoscs
approved these changes
Nov 4, 2025
socksy
commented
Nov 4, 2025
| def __getattr__(name: str) -> any: | ||
| def __getattr__(name: str): |
ContributorAuthor
There was a problem hiding this comment.
- This should have been Any
- having it here meant that typechecking doesn't actually do anything meaningful, which defeats the whole point
socksy
commented
Nov 4, 2025
ContributorAuthor
rerequesting a review @konstantinoscs because the change before was dramatically less than it is now |
socksyforce-pushed
the
feature/tow-1131-add-pytyped-to-python-sdk
branch
from
November 4, 2025 20:39
fd0800b to
1149f6bComparekonstantinoscs
approved these changes
Nov 4, 2025
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves TOW-1131
See title :) No more needed to be done since there's already types, this just lets tooling know that there are types defined in the library itself it can use. See PEP 561