Skip to content

fix: follow a finished run's logs through the stream endpoint - #363

Open
socksy wants to merge 2 commits into
developfrom
fix/follow-via-stream
Open

fix: follow a finished run's logs through the stream endpoint#363
socksy wants to merge 2 commits into
developfrom
fix/follow-via-stream

Conversation

@socksy

@socksysocksy commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

tower apps logs --follow on a just-finished run can print nothing: the follow path fetched stored logs once, and the store lags a run's terminal status. This is why the monorepo CLI regression job fails consistently on cli_runs.feature:58. Now every follow attaches to the log stream, which replays from the start and closes itself; the finished-run special cases are deleted. The first commit gives the mock the same persistence lag, reproducing the failure; the second makes it pass. Full suite green against the mock and a real backend at develop.

@coderabbitai

coderabbitaiBot commented Aug 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5f1be3a4-9ca2-4f37-8fe6-52a6cf9c769e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@socksy
socksyforce-pushed the fix/follow-via-stream branch from ee15846 to 167ad88CompareAugust 19, 2026 14:36
@socksy
socksyforce-pushed the fix/follow-via-stream branch from 167ad88 to 780186cCompareAugust 19, 2026 14:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@socksy