Uh oh!
There was an error while loading. Please reload this page.
fix: follow a finished run's logs through the stream endpoint - #363
Open
socksy wants to merge 2 commits into
Open
fix: follow a finished run's logs through the stream endpoint#363socksy wants to merge 2 commits into
socksy wants to merge 2 commits into
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
socksyforce-pushed
the
fix/follow-via-stream
branch
from
August 19, 2026 14:36
ee15846 to
167ad88Comparesocksyforce-pushed
the
fix/follow-via-stream
branch
from
August 19, 2026 14:45
167ad88 to
780186cCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tower apps logs --followon a just-finished run can print nothing: the follow path fetched stored logs once, and the store lags a run's terminal status. This is why the monorepo CLI regression job fails consistently on cli_runs.feature:58. Now every follow attaches to the log stream, which replays from the start and closes itself; the finished-run special cases are deleted. The first commit gives the mock the same persistence lag, reproducing the failure; the second makes it pass. Full suite green against the mock and a real backend at develop.