Skip to content

Canonicalize GraalPy implementation name. - #73

Merged
gaborbernat merged 2 commits into
tox-dev:mainfrom
timfel:graalpy-implementation-alias
May 12, 2026
Merged

Canonicalize GraalPy implementation name.#73
gaborbernat merged 2 commits into
tox-dev:mainfrom
timfel:graalpy-implementation-alias

Conversation

@timfel

Copy link
Copy Markdown
Contributor

GraalPy reports "GraalVM" for platform.python_implementation() and "graalpy" for sys.implementation.name, so this canonicalizes on "graalpy".

@gaborbernatgaborbernat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timfel
timfelforce-pushed the graalpy-implementation-alias branch from 81ef00c to 4b41b4bCompareMay 12, 2026 15:22
@timfel
timfel requested a review from gaborbernatMay 12, 2026 15:29

@gaborbernatgaborbernat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing.

@timfel

Copy link
Copy Markdown
ContributorAuthor

CI failing.

Yes, coverage dropped to 99%. I'll add a test

@timfel
timfelforce-pushed the graalpy-implementation-alias branch from 4b41b4b to e5c7ae9CompareMay 12, 2026 18:38
@gaborbernat
gaborbernat enabled auto-merge (squash) May 12, 2026 18:42
@gaborbernat
gaborbernat merged commit 68f7dc1 into tox-dev:mainMay 12, 2026
13 checks passed
@timfel
timfel deleted the graalpy-implementation-alias branch May 13, 2026 06:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@timfel@gaborbernat