Uh oh!
There was an error while loading. Please reload this page.
🐛 fix(spec): allow dots in machine/ISA specifier - #78
Merged
Conversation
The regex for parsing machine names only accepted `[a-zA-Z0-9_]`, which rejected platforms like OpenIndiana where `platform.machine()` returns `i86pc.64bit`. Fixes#75
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On OpenIndiana,
platform.machine()returnsi86pc.64bit, which contains a dot. The spec parser regex for the machine group only accepted[a-zA-Z0-9_], so any spec string built from such a machine value failed to parse. This causedtest_py_info_satisfies_with_machineto fail on that platform.🔧 Adding
.to the character class in themachinecapture group fixes parsing for dotted machine identifiers while remaining backward-compatible with all existing values likearm64,x86_64, andppc64le.Fixes#75