Uh oh!
There was an error while loading. Please reload this page.
feat(fr-gate): promotion-shape guard — only the train promotes - #104
Merged
Conversation
Manual promotion PRs (head=staging/develop into prod branches) bypass the train's Bugbot soft-gate, tagging and records, and indirect-merge its PRs (backend#1336, 2026-07-29). The gate now fails any promotion-target PR whose head is not release-train/* or hotfix-backmerge/*, unless labeled 'hotfix' (D14a emergency lane) or 'skip-fr-gate' (audited override). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
LukasWodka
commented
Jul 29, 2026
ContributorAuthor
👋 Heads-up — Code review queue is at 33 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening from today's parallel-promotion collision (backend#1336 indirect-merging the train's #1326): the gate now fails any PR targeting staging/main/master whose head isn't
release-train/*orhotfix-backmerge/*, with an instructive error pointing at the train. Escapes:hotfixlabel (D14a single-repo lane) andskip-fr-gate(existing audited override). The old fashion stops compiling.🤖 Generated with Claude Code
Note
Low Risk
Workflow-only enforcement on promotion PR shape; escapes for train branches, hotfix back-merges, hotfix label, and skip-fr-gate are unchanged in intent.
Overview
Adds a promotion-shape guard to the reusable FR gate so PRs into
staging,main, ormastermust come from sanctioned lanes, not ad-hoc manual promotions.The new step runs after the existing
skip-fr-gatecheck and fails the job when the head ref is notrelease-train/*orhotfix-backmerge/*and the PR lacks thehotfixlabel. The error message directs teams to the release train workflow and documents the emergency overrides (hotfix,skip-fr-gate). A short comment notes thatskip-fr-gatealso skips this guard.Reviewed by Cursor Bugbot for commit 0e5f5a7. Bugbot is set up for automated code reviews on this repo. Configure here.