Uh oh!
There was an error while loading. Please reload this page.
fix(ci): tighten PR-ref extraction + tolerate missing PRs in advance-deploy-env - #11
Merged
Merged
Conversation
…deploy-env Found via verification test on tracebloc/model-zoo#52: a commit body containing 'Closes#47' (an issue ref) caused gh api to fail when looking up #47 as a PR, which aborted the whole workflow because of set -e. Two surgical fixes: 1. Extract PR refs from commit *subjects* only — match exact patterns '(#NNN)' (squash merge) and 'Merge pull request #NNN' (merge commit). Issue refs in commit bodies are no longer picked up. 2. Wrap the gh api call in '|| RESP=\'{}\'' so a non-PR number degrades to 'skip cleanly' instead of failing the job. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caught via verification test: PR body containing
Closes #47(issue ref) caused the workflow to look up #47 as a PR, which 404s, which aborts the whole job.Two surgical fixes:
(#NNN)(squash merge) andMerge pull request #NNN(merge commit) patterns.gh apifailure no longer fails the workflow; treats as "not a PR, skip."🤖 Generated with Claude Code