Uh oh!
There was an error while loading. Please reload this page.
fix(code-quality): black-version default 23.1.0 → 26.3.1 - #117
Merged
Conversation
The 23.1.0 default rested on a measurement that was itself the bug: black 23.1.0 cannot run on Python 3.12+ (ast.Str removed), so it errored on every file while printing zero 'would reformat' lines, which read as '0 dirty -- pure version skew'. Re-measured on 3.11: NO repo is 23.1.0-clean; backend is 0-dirty under 26.3.1 (its own gate's pin) and every other repo has a real backlog under both. 26.3.1 is also what the pre-commit hooks pin, so local and CI agree. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The 23.1.0 default rested on a measurement that was itself the bug: black 23.1.0 cannot run on Python 3.12+ (ast.Str removed), so it errored on every file while printing zero 'would reformat' lines -- which read as '0 dirty, pure version skew'. Re-measured on 3.11: no repo is 23.1.0-clean; backend is 0-dirty under 26.3.1 (its own gate's pin) and every other repo has a real backlog under both versions. 26.3.1 also matches the pre-commit pins, so local and CI agree. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
LukasWodka
commented
Jul 31, 2026
ContributorAuthor
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b6d9488. Configure here.
aptracebloc
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
23.1.0default I shipped in #115 rested on a measurement that was itself the bug.black 23.1.0 cannot run on Python 3.12+ (it calls
ast.Str, removed in 3.12): it errors on every file witherror:/would fail to reformatwhile printing zerowould reformatlines. Grepping only the latter turned "black crashed" into a confident "0 dirty — pure version skew, no backlog".Re-measured on Python 3.11 (zero parse errors, so real verdicts):
No repo is 23.1.0-clean. 26.3.1 is what backend is clean under, what the pre-commit hooks pin (engine, data-ingestors), and it runs on current Python. Callers should still pin explicitly — the doc string now says why.
Part of tracebloc/backend#1382
🤖 Generated with Claude Code
Note
Low Risk
Workflow default and documentation only; callers can still override
black-version, with no auth or runtime product impact.Overview
Bumps the shared
black-versiondefault from23.1.0to26.3.1in.github/workflows/code-quality.ymlfor repos that opt into theformatjob without overriding the pin.The
black-versioninput description is rewritten: it no longer claims fleet-wide cleanliness under 23.1.0, and instead tells callers to pin black in sync with pre-commit. It documents that 23.1.0 breaks on Python 3.12+ (ast.Str), can error on every file withoutwould reformatlines, and that 26.3.1 matches backend’s gate and org pre-commit pins while running on current Python.Reviewed by Cursor Bugbot for commit b6d9488. Bugbot is set up for automated code reviews on this repo. Configure here.