Skip to content

fix(code-quality): black-version default 23.1.0 → 26.3.1 - #117

Merged
LukasWodka merged 2 commits into
developfrom
fix/black-default-version
Jul 31, 2026
Merged

fix(code-quality): black-version default 23.1.0 → 26.3.1#117
LukasWodka merged 2 commits into
developfrom
fix/black-default-version

Conversation

@LukasWodka

@LukasWodkaLukasWodka commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

The 23.1.0 default I shipped in #115 rested on a measurement that was itself the bug.

black 23.1.0 cannot run on Python 3.12+ (it calls ast.Str, removed in 3.12): it errors on every file with error:/would fail to reformat while printing zerowould reformat lines. Grepping only the latter turned "black crashed" into a confident "0 dirty — pure version skew, no backlog".

Re-measured on Python 3.11 (zero parse errors, so real verdicts):

repoblack 23.1.0black 26.3.1
backend260 ← its own gate's pin
tracebloc-engine148157
tracebloc-py-package125168
data-ingestors7878
averaging-service4971
client-runtime1415

No repo is 23.1.0-clean. 26.3.1 is what backend is clean under, what the pre-commit hooks pin (engine, data-ingestors), and it runs on current Python. Callers should still pin explicitly — the doc string now says why.

Part of tracebloc/backend#1382

🤖 Generated with Claude Code


Note

Low Risk
Workflow default and documentation only; callers can still override black-version, with no auth or runtime product impact.

Overview
Bumps the shared black-version default from 23.1.0 to 26.3.1 in .github/workflows/code-quality.yml for repos that opt into the format job without overriding the pin.

The black-version input description is rewritten: it no longer claims fleet-wide cleanliness under 23.1.0, and instead tells callers to pin black in sync with pre-commit. It documents that 23.1.0 breaks on Python 3.12+ (ast.Str), can error on every file without would reformat lines, and that 26.3.1 matches backend’s gate and org pre-commit pins while running on current Python.

Reviewed by Cursor Bugbot for commit b6d9488. Bugbot is set up for automated code reviews on this repo. Configure here.

LukasWodkaand others added 2 commits July 31, 2026 10:27
The 23.1.0 default rested on a measurement that was itself the bug: black
23.1.0 cannot run on Python 3.12+ (ast.Str removed), so it errored on every
file while printing zero 'would reformat' lines, which read as '0 dirty --
pure version skew'. Re-measured on 3.11: NO repo is 23.1.0-clean; backend is
0-dirty under 26.3.1 (its own gate's pin) and every other repo has a real
backlog under both. 26.3.1 is also what the pre-commit hooks pin, so local
and CI agree.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The 23.1.0 default rested on a measurement that was itself the bug: black
23.1.0 cannot run on Python 3.12+ (ast.Str removed), so it errored on every
file while printing zero 'would reformat' lines -- which read as '0 dirty,
pure version skew'. Re-measured on 3.11: no repo is 23.1.0-clean; backend is
0-dirty under 26.3.1 (its own gate's pin) and every other repo has a real
backlog under both versions. 26.3.1 also matches the pre-commit pins, so
local and CI agree.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@LukasWodka

Copy link
Copy Markdown
ContributorAuthor

bugbot run

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit b6d9488. Configure here.

@LukasWodka
LukasWodka merged commit 19fd8d6 into developJul 31, 2026
2 checks passed
@LukasWodka
LukasWodka deleted the fix/black-default-version branch August 1, 2026 21:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@LukasWodka@aptracebloc