Uh oh!
There was an error while loading. Please reload this page.
promote: develop -> main (D30 self-signoff relaxation) - #120
Merged
Conversation
Functional review still requires a human to assert it; it no longer has to be a different human from the author. Rationale (RFC-BACKEND-1405 D6): code review already puts a second person on the diff, and most implementation is AI-assisted, so requiring a *separate* human for the functional review was ceremony rather than a control. At our size it was also a throughput ceiling — on 2026-08-01, 3 of 17 /fr-pass comments were refused as self-signoff and the cards had to be moved by hand, which is strictly worse than allowing the sign-off: the control was bypassed rather than satisfied. Flipping the reusable's default applies this org-wide in one change, because the per-repo callers pass no inputs. A repo that wants the stricter rule can set allow-self-signoff: false on its caller. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
policy: allow self sign-off on functional review (retire D30)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries #119 to
main, where the callers consume it (all 14 pin@main)..githubhas no develop→main promotion path yet (#1420 covers enrolling it), so this is a one-off manual promotion withenforce_adminslifted for the duration, at Lukas's explicit instruction. It will be re-enabled immediately after merge.Note
Medium Risk
Changes org-wide release governance defaults for who can advance cards to production readiness; logic is a single default flip with an explicit per-repo override.
Overview
Org-wide functional review policy: the reusable
fr-pass-commentworkflow now defaultsallow-self-signoffto true, retiring D30’s “different human for/fr-pass” rule (RFC-BACKEND-1405 D6).Because callers pin
@mainand do not override inputs, PR authors with write access can/fr-passtheir own kanban cards on normal work; functional review still requires a human assertion, but not a second person. Callers can setallow-self-signoff: falseto restore the stricter rule for one repo. Release-train promotion PRs remain exempt as before.Reviewed by Cursor Bugbot for commit dee9920. Bugbot is set up for automated code reviews on this repo. Configure here.