Skip to content

docs(ci): /fr-pass advances staging → prod only (backend#1405 D6) - #123

Merged
LukasWodka merged 1 commit into
developfrom
docs/fr-pass-caller-staging-only
Aug 1, 2026
Merged

docs(ci): /fr-pass advances staging → prod only (backend#1405 D6)#123
LukasWodka merged 1 commit into
developfrom
docs/fr-pass-caller-staging-only

Conversation

@LukasWodka

@LukasWodkaLukasWodka commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

The header comment on this repo's /fr-pass caller describes a transition that does not exist:

# from "FR on dev" → "Ready for staging" or "FR on staging" → "Ready for prod".

RFC-BACKEND-1405 D6 retired the dev-side review.On dev is now set automatically when the release train merges to develop, so there is no FR on dev column and nothing for /fr-pass to advance before staging. /fr-pass has exactly one gate: FR on stagingReady for prod.

The reusable workflow this calls (tracebloc/.github, .github/workflows/fr-pass-comment.yml) has only ever implemented the staging hop, and documents it correctly at the top of the file:

# FR on staging → Ready for prod
# (D6: the dev-side review is gone — "On dev" is automatic — so /fr-pass only
# applies at staging, the single functional-review gate.)

Verified against the reusable's implementation: the only transition in its column table is "FR on staging") NEXT="Ready for prod", and its refusal message states that /fr-pass"only advances FR on staging → Ready for prod (the one functional-review gate)". So this was the comment drifting away from the code.

Comment-only. No logic, no triggers, no inputs changed.

Scope note

This stale comment is byte-identical across 14 repos, plus a differently-worded copy in the tracebloc/.github template it was copied from. A pull request cannot span repositories, so this is one of 15 PRs — the template in tracebloc/.github included, because leaving that one stale would reintroduce the drift on the next copy.

🤖 Generated with Claude Code


Note

Low Risk
Documentation-only change to workflow header comments; no CI logic, triggers, or runtime behavior is modified.

Overview
Updates the header comments on the /fr-pass caller workflow template so they match how the shortcut actually works after RFC-BACKEND-1405 D6.

The docs now state that /fr-pass only advances FR on stagingReady for prod (the single functional-review gate), and that On dev is automatic when the release train merges to develop—there is no FR on dev column or dev-side hop. It also notes this file is the source template copied into per-repo workflows, so outdated transition text would spread on the next copy.

No workflow triggers, jobs, reusable reference, or secrets behavior changed—comment-only.

Reviewed by Cursor Bugbot for commit 4606723. Bugbot is set up for automated code reviews on this repo. Configure here.

The caller's header described a "FR on dev" -> "Ready for staging" transition
that does not exist. RFC-BACKEND-1405 D6 retired the dev-side review -- "On dev"
is set automatically when the train merges to develop -- so /fr-pass applies at
exactly one gate: FR on staging -> Ready for prod.
The reusable workflow it calls has only ever implemented the staging hop and
documents that correctly at the top of the file, so this was the comment drifting
away from the code, not a behaviour change. Comment-only; no logic touched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@LukasWodka

Copy link
Copy Markdown
ContributorAuthor

👋 Heads-up — Code review queue is at 36 / 30

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

@LukasWodka
LukasWodka merged commit a395d15 into developAug 1, 2026
5 checks passed
@LukasWodka
LukasWodka deleted the docs/fr-pass-caller-staging-only branch August 1, 2026 21:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@LukasWodka