Skip to content

fix(inventory): model-zoo and start-training now have a code-quality caller - #136

Merged
LukasWodka merged 1 commit into
developfrom
fix/1420-code-quality-exemptions-stale
Aug 4, 2026
Merged

fix(inventory): model-zoo and start-training now have a code-quality caller#136
LukasWodka merged 1 commit into
developfrom
fix/1420-code-quality-exemptions-stale

Conversation

@LukasWodka

@LukasWodkaLukasWodka commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

The drift guard caught my own change — which is the outcome #1415 was built for.

model-zoo#115 and start-training#32 added code-quality callers this morning. Their inventory entries still read exempt: *code_quality_caller_missing, so audit on .github/develop reported:

model-zoo: code-quality.yml is marked `exempt` but a caller exists (code-quality-caller.yml)
start-training: code-quality.yml is marked `exempt` but a caller exists (code-quality-caller.yml)

Both now required # code-quality-caller.yml. Verified live: 20 of 20 repos read, no drift. Selftest 42/42.

Context on the audit that was red

The run that fired at 09:56:39 reported four findings, not two — it was triggered by .github#135 merging and ran beforerelease-train#25 merged at 09:59:03. Two of those four were the expected transient on-train drift, which cleared on its own. The other two are the ones this PR fixes, and they were never transient.

So the red audit had two independent causes stacked, and only one of them resolved itself. Worth noting because "it will go green when the pair merges" was my prediction, and it was half right.

Third instance of the same coupling today

#fact recorded in two placeswhat drifted
1release-train/repos.yml ↔ inventory release_traintracebloc-website (.github#132)
2same pairmodel-zoo, start-training (.github#135)
3a caller file ↔ its inventory entrythis PR

Identical shape each time: a fact asserted in two repos where only one got edited. The guard is doing exactly its job, and three catches in one day is a reasonable argument that it earns its keep — but it is also a signal that the coupling itself is the defect, not the individual misses.

Anchor text corrected

The shared code_quality_caller_missing reason still implied all nine original citations stood. It is down to threeclaude-skills, docs, release-train — and the anchor now names them and what remediated the other two, so the next reader does not have to re-derive the count from grep. The anchor stays (three repos still cite it), so this is not a dangling reference.


Note

Low Risk
Inventory-only metadata changes; no workflow or runtime behavior is modified.

Overview
Aligns repo-inventory.yml with callers that already landed in model-zoo and start-training, so the caller-drift guard stops reporting “exempt but a caller exists.”

For both repos, code-quality.yml moves from exempt: *code_quality_caller_missing to required (with code-quality-caller.yml noted in the comment). The shared code_quality_caller_missing anchor text is updated to say only claude-skills, docs, and release-train still use that exemption, and that model-zoo/start-training were remediated under backend#1420.

Reviewed by Cursor Bugbot for commit d471f96. Bugbot is set up for automated code reviews on this repo. Configure here.

…caller
The drift guard caught my own change. model-zoo#115 and start-training#32
added code-quality callers this morning; their inventory entries still said
`exempt: *code_quality_caller_missing`, so `audit` reported
model-zoo: code-quality.yml is marked `exempt` but a caller exists
start-training: code-quality.yml is marked `exempt` but a caller exists
Both flipped to `required # code-quality-caller.yml`. Audit now clean: 20 of
20 read, no drift. Selftest 42/42.
Third instance today of the same two-file coupling -- adding a caller, or
enrolling a repo, without updating the inventory that asserts the fact. The
earlier two were release_train booleans (.github#132, #135); this one is a
caller-vs-exemption pair. The shape is identical: a fact recorded in two repos
where only one got edited.
Also corrected the shared anchor's text, which still implied all nine original
citations stood. Down to three -- claude-skills, docs, release-train -- and the
anchor now names them plus what remediated the other two, so the next reader
does not have to re-derive the count from grep.
Refs #1420, #1415
@LukasWodka
LukasWodka merged commit 1781b51 into developAug 4, 2026
6 checks passed
@LukasWodka
LukasWodka deleted the fix/1420-code-quality-exemptions-stale branch August 14, 2026 13:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@LukasWodka@saadqbal@divyasinghds