Uh oh!
There was an error while loading. Please reload this page.
fix(inventory): model-zoo and start-training now have a code-quality caller - #136
Merged
Merged
Conversation
…caller The drift guard caught my own change. model-zoo#115 and start-training#32 added code-quality callers this morning; their inventory entries still said `exempt: *code_quality_caller_missing`, so `audit` reported model-zoo: code-quality.yml is marked `exempt` but a caller exists start-training: code-quality.yml is marked `exempt` but a caller exists Both flipped to `required # code-quality-caller.yml`. Audit now clean: 20 of 20 read, no drift. Selftest 42/42. Third instance today of the same two-file coupling -- adding a caller, or enrolling a repo, without updating the inventory that asserts the fact. The earlier two were release_train booleans (.github#132, #135); this one is a caller-vs-exemption pair. The shape is identical: a fact recorded in two repos where only one got edited. Also corrected the shared anchor's text, which still implied all nine original citations stood. Down to three -- claude-skills, docs, release-train -- and the anchor now names them plus what remediated the other two, so the next reader does not have to re-derive the count from grep. Refs #1420, #1415
saadqbal
approved these changes
Aug 4, 2026
Uh oh!
There was an error while loading. Please reload this page.
LukasWodka added a commit
that referenced
this pull request
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The drift guard caught my own change — which is the outcome #1415 was built for.
model-zoo#115andstart-training#32added code-quality callers this morning. Their inventory entries still readexempt: *code_quality_caller_missing, soauditon.github/developreported:Both now
required # code-quality-caller.yml. Verified live: 20 of 20 repos read, no drift. Selftest 42/42.Context on the audit that was red
The run that fired at
09:56:39reported four findings, not two — it was triggered by.github#135merging and ran beforerelease-train#25merged at09:59:03. Two of those four were the expected transient on-train drift, which cleared on its own. The other two are the ones this PR fixes, and they were never transient.So the red
audithad two independent causes stacked, and only one of them resolved itself. Worth noting because "it will go green when the pair merges" was my prediction, and it was half right.Third instance of the same coupling today
release-train/repos.yml↔ inventoryrelease_traintracebloc-website(.github#132)model-zoo,start-training(.github#135)Identical shape each time: a fact asserted in two repos where only one got edited. The guard is doing exactly its job, and three catches in one day is a reasonable argument that it earns its keep — but it is also a signal that the coupling itself is the defect, not the individual misses.
Anchor text corrected
The shared
code_quality_caller_missingreason still implied all nine original citations stood. It is down to three —claude-skills,docs,release-train— and the anchor now names them and what remediated the other two, so the next reader does not have to re-derive the count from grep. The anchor stays (three repos still cite it), so this is not a dangling reference.Note
Low Risk
Inventory-only metadata changes; no workflow or runtime behavior is modified.
Overview
Aligns repo-inventory.yml with callers that already landed in model-zoo and start-training, so the caller-drift guard stops reporting “exempt but a caller exists.”
For both repos,
code-quality.ymlmoves fromexempt: *code_quality_caller_missingtorequired(withcode-quality-caller.ymlnoted in the comment). The sharedcode_quality_caller_missinganchor text is updated to say only claude-skills, docs, and release-train still use that exemption, and that model-zoo/start-training were remediated under backend#1420.Reviewed by Cursor Bugbot for commit d471f96. Bugbot is set up for automated code reviews on this repo. Configure here.