Uh oh!
There was an error while loading. Please reload this page.
feat(inventory): .github is on the train and has an fr-gate caller - #139
Merged
Conversation
The follow-up the file's own note prescribes: "Adding a caller and flipping its entry to `required` in the same PR therefore fails, because the caller is not on develop yet. Land the caller first, flip the entry after." .github#137 landed the caller and release-train#26 enrolled the repo, so both facts are now true and this records them: release_train false -> true fr-gate.yml exempt: *no_staging_branch_no_hop_to_gate -> required That exemption was accurate until today -- .github genuinely had no staging branch, so there was no hop to gate. It has one now (created from main @ ee105ce so its ancestry already contains prod's), and RFC-BACKEND-1405 open question 3 is answered in favour of branch promotion, which puts this repo on the same develop -> staging -> main path as everything else. Audit with this change: 2 findings, both rfcs entries that .github#138 fixes. Without it: 4. Selftest 42/42. Refs #1420, #1405
saadqbal
approved these changes
Aug 4, 2026
saadqbal
self-requested a review
August 4, 2026 12:46
saadqbal
approved these changes
Aug 4, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The follow-up this file's own note prescribes:
.github#137landed the fr-gate caller andrelease-train#26enrolled the repo, so both facts are now true:release_trainfalsetruefr-gate.ymlexempt: *no_staging_branch_no_hop_to_gaterequiredThat exemption was accurate until today —
.githubgenuinely had nostagingbranch, so there was no hop to gate. It has one now (created frommain@ee105cea, so its ancestry already contains prod's), and RFC-BACKEND-1405's open question 3 is answered in favour of branch promotion, which puts this repo on the samedevelop → staging → mainpath as everything else.Verified
rfcsentries that.github#138fixes..github: release_trainmismatch and.github: fr-gate exempt but a caller exists.caller-drift-selftest.py: 42 pass, 0 fail.Sequencing note
This is the fifth cross-repo caller change today that produced a transient red window, and the note quoted above is why this one was unavoidable rather than sloppy: the guard reads the inventory from the checkout but caller state from the live branch, so the assertion cannot be true in the same commit that makes it true.
Bugbot made the same point on
#137when I had bundled therelease_trainflip there — it correctly noted the PR would fail its own validation. Splitting it out is what let#137merge green.Note
Low Risk
Single-file inventory metadata only; no runtime or auth changes, just aligning the drift guard with merged workflow and branch setup.
Overview
Updates
repo-inventory.ymlfor.githubso the caller-drift guard matches what already landed elsewhere:release_trainistrue(aligned with release-train enrollment), andfr-gate.ymlisrequiredinstead of exempt under no staging branch.That exemption is dropped because
.githubnow has astagingbranch and anfr-gate-caller.ymlon develop; the inventory flip is intentionally sequenced after those changes so the guard (inventory from checkout, caller state from the live branch) stays green.Reviewed by Cursor Bugbot for commit ba40ced. Bugbot is set up for automated code reviews on this repo. Configure here.