Uh oh!
There was an error while loading. Please reload this page.
docs(code-quality): note callers pass secrets: inherit for consistency (backend#1420) - #142
Conversation
…y (backend#1420) Reflect the fleet-wide convention: callers now pass secrets: inherit even though this reusable uses no secrets. Clarifies it's a no-op bounded by the permissions block, adopted to clear a recurring Cursor Bugbot false positive. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
aptracebloc
commented
Aug 4, 2026
Approving the caller PRs — they're correct and a genuine no-op today. Flagging a reservation on the convention itself, since it's about to become fleet-wide precedent. The "harmless no-op" framing is accurate but conditional: So the reservation is with the mechanism, not the goal: we're changing security-relevant config across ~10 repos to silence a Bugbot false positive, when a Not blocking — the current PRs are safe and I've approved them. But I'd like to revisit before this is cemented as the fleet convention; the BUGBOT.md-rule approach looks strictly cleaner. At minimum the caller comment should state the condition ("a no-op while this reusable references no secrets; revisit if that changes") rather than an unqualified "harmless." |
aptracebloc
left a comment
There was a problem hiding this comment.
Approving. See my comment on this PR: safe as documented today, but I'd revisit the mechanism (a .cursor/BUGBOT.md rule) before cementing secrets:inherit as the fleet convention.
Uh oh!
There was an error while loading. Please reload this page.
…d the other way (backend#1526) Callers pass NO secrets line (RFC-BACKEND-1405 Q5): the no-op was conditional on this file staying secretless, and @main floating means a future secrets reference reaches every inheriting caller's full secret set at once. Explicit per-secret passing if ever needed; the Bugbot nag dies in per-repo BUGBOT.md rules, and the INVERSE (a caller adding inherit) is what now deserves a finding. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…d the other way (backend#1526) (#147) Callers pass NO secrets line (RFC-BACKEND-1405 Q5): the no-op was conditional on this file staying secretless, and @main floating means a future secrets reference reaches every inheriting caller's full secret set at once. Explicit per-secret passing if ever needed; the Bugbot nag dies in per-repo BUGBOT.md rules, and the INVERSE (a caller adding inherit) is what now deserves a finding. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Header-comment-only change to the
code-quality.ymlreusable. Documents the fleet-wide convention (backend#1420) that callers passsecrets: inheriteven though this workflow uses no secrets — a no-op bounded by thepermissions:block, adopted to clear Cursor Bugbot's recurring (false-positive) "omits secrets inheritance" finding.Companion to the four caller PRs: docs#79, tracebloc-website#454, model-zoo#117, start-training#33.
No behaviour change. Parent: backend#1420
🤖 Generated with Claude Code
Note
Low Risk
Comment-only change to workflow documentation; no runtime, permissions, or secret usage changes.
Overview
Header comments only in the reusable
code-quality.ymladoption example—no workflow behavior change.The sample caller now includes
secrets: inheritwith a note below it. The old text said callers do not need that line; it now explains the fleet convention from backend#1420: callers passsecrets: inheritfor consistency even though this reusable workflow references no secrets and only needscontents: read. That inheritance is documented as a no-op bounded by the jobpermissions:block, mainly to silence recurring Cursor Bugbot false positives about missing secret inheritance.Reviewed by Cursor Bugbot for commit d06af4e. Bugbot is set up for automated code reviews on this repo. Configure here.