Uh oh!
There was an error while loading. Please reload this page.
fix(inventory): two exemptions went stale the moment their callers landed (backend#1420) - #143
Merged
Merged
Conversation
…nded (backend#1420) The caller-drift audit failed on the `.github` develop -> staging hop (#140) with two findings, both real: - .github: public-pii-gate.yml marked `exempt` but public-pii-gate-caller.yml exists - docs: code-quality.yml marked `exempt` but code-quality-caller.yml exists Both callers were added TODAY under backend#1420 (.github#141, and docs' code-quality caller) and neither entry was flipped. This is the same two-file coupling as repos.yml vs release_train, and the third time this session it has been the guard rather than a human that noticed. Flipped both to `required` with per-caller reasons rather than a bare value, and recorded what each gate can actually do: - docs' code-quality is that repo's ONLY content gate (off-train, python:false / shell:false measured), so gitleaks + house-rules are the real checks; soft-fail stays advisory until a first green run. - .github's PII gate is PRESENCE, NOT TEETH: the reusable is unarmed org-wide (PII_DENYLIST unset, backend#1409, now parked in the backlog), so it runs green without inspecting anything. `required` asserts the caller exists -- what this file tracks -- not that the gate can fail. Saying so here beats a future reader inferring teeth from the word `required`. Also corrected the code_quality_caller_missing anchor: it claimed THREE citations and named claude-skills, docs and release-train while FOUR entries aliased it -- `rfcs` was added later in the same session and never listed. Now three for real (claude-skills, release-train, rfcs), with a note to trust grep over the sentence. Verified: PyYAML parse OK (20 repos), selftest 42/42, and the real audit run against live org state reports "No drift. Every repo read, every entry matched." (20 of 20).
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The caller-drift
auditfailed on the.githubdevelop → staging hop (#140) — the first hop this repo has ever run — with two findings. Both are real:.githubpublic-pii-gate.yml: exemptpublic-pii-gate-caller.ymlexists (added in #141, today)docscode-quality.yml: exemptcode-quality-caller.ymlexists (added today)Both callers landed today under backend#1420 and neither inventory entry was flipped. Same two-file coupling as
repos.ymlvsrelease_train, and the third time this session the guard caught it rather than a person.What changed
Flipped both to
required— with per-caller reasons, not a bare value, because what each gate can actually do differs:docscode-quality is that repo's only content gate (off-train, andpython:false/shell:falseare measured — 0.py, 0.sh). So gitleaks + house-rules are the real checks.soft-failstays at its advisory default until a first green run is observed; arming it required onmainis a follow-up..githubpublic-pii-gate is presence, not teeth, and deliberately so. The reusable is unarmed org-wide (PII_DENYLISTunset, backend#1409 — now parked in the backlog by decision, since the org is likely to be restructured first). It runs green on every PR without inspecting anything.requiredasserts the caller exists, which is what this inventory tracks; it does not assert the gate can fail. Stating that here beats a future reader inferring teeth from the wordrequired.Also corrected the
code_quality_caller_missinganchor. It said THREE citations and named claude-skills / docs / release-train, while FOUR entries aliased it —rfcswas added later in the same session and never listed. Now three for real (claude-skills, release-train, rfcs), plus a note to trust a grep over the prose, since a hand-maintained citation list drifts from its own aliases.Verified
Merging this unblocks #140, which is
.github's firstdevelop → stagingpromotion and the last of D1's five enrolments (backend#1420).Note
Low Risk
Inventory-only metadata aligned with existing callers; no workflow or gate behavior changes in this diff.
Overview
Updates
repo-inventory.ymlso caller-drift audit matches repos where workflows were added today but inventory still said exempt..github—public-pii-gate.ymlis nowrequired(caller landed in #141). Comments spell out presence, not teeth: org-widePII_DENYLISTis unset (#1409, parked), so the gate always greens;requiredonly means the caller exists.docs—code-quality.ymlis nowrequiredaftercode-quality-caller.ymllanded; notes that off-train docs relies on gitleaks + house-rules withpython:false/shell:false, and that making the check required onmainis follow-up after a green run.code_quality_caller_missinganchor — Prose now lists three remaining aliases (claude-skills, release-train, rfcs), includes docs remediation, and warns that hand-maintained citation lists drift from YAML aliases—prefer grep over the sentence.Reviewed by Cursor Bugbot for commit 76bc97a. Bugbot is set up for automated code reviews on this repo. Configure here.