Uh oh!
There was an error while loading. Please reload this page.
docs(code-quality): baselines assume gitleaks git mode — record the dependency (backend#1404 §4) - #150
Merged
Merged
Conversation
…ependency (backend#1404 §4) Baseline fingerprints embed the introducing commit SHA, so they only match git-mode scans. A future switch to dir/detect would silently un-suppress all 277 baselined findings fleet-wide in one run, and nothing recorded that coupling until now. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only. Step 4 of backend#1404: all three gitleaks invocations are commit-scoped (
gitleaks git), and the fleet's baseline fingerprints embed the introducing commit SHA — so they only match git-mode scans. A future switch of any branch todir/detect(path-scoped fingerprints) would silently invalidate every baseline entry at once, and nothing recorded that coupling. Now the dependency is written where the person changing the invocation will read it, together with the toml-vs-baseline split (fixtures → commit-independent.gitleaks.toml; genuine exposure → baseline + #1355 rotation).Sibling PRs landing under the same ticket roll the allowlists out to 7 repos.
Part of tracebloc/backend#1404.
🤖 Generated with Claude Code
Note
Low Risk
Documentation-only; no changes to gitleaks invocation, baselines, or CI behavior.
Overview
Comment-only change in the shared
code-qualityworkflow’s gitleaks step: adds inline documentation that all scan paths usegitleaks git(commit-scoped) and that per-repo baseline suppressions only work with that mode because fingerprints include the introducing commit SHA.The comment warns that switching any branch to
gitleaks dir/detectwould invalidate fleet baselines in one run (~277 suppressions per backend#1404 §4), and clarifies the split between commit-independent.gitleaks.tomlallowlists for fixtures vs baselines for genuine historical exposure (rotation tracked in backend#1355).No workflow behavior changes — scan commands and flags are unchanged.
Reviewed by Cursor Bugbot for commit 6ded637. Bugbot is set up for automated code reviews on this repo. Configure here.