Uh oh!
There was an error while loading. Please reload this page.
fix(inventory): e2e-test-agent's nine exemptions are remediated (backend#1552) - #153
Merged
Merged
Conversation
…end#1552) e2e-test-agent#13 added the .github/workflows directory this repo had lacked since it was created on 2026-06-03, so nine `exempt` entries now assert the opposite of reality — `exempt` means the caller must be ABSENT, and all nine are present. Left alone, the next scheduled caller-drift run goes red for a gap that has just been closed. This was the largest single-repo block of UNREMEDIATED exemptions in the file: 11 of the 21 org-wide, where the next worst repo has 3. The harm they recorded was not hypothetical — no issue or PR in the repo had ever reached the board, which is why e2e-test-agent#11 sat open and unreviewed for seven days. Flipped to the private-train-repo template, identical to frontend-app: seven required callers, public-pii-gate exempt (private repo), wip-limit-check exempt (retired org-wide), both copies required. RFC-BACKEND-1405 D1 always required this — "Exempt never means ungoverned: every repo keeps branch protection, the code-quality caller and kanban auto-add" — so this is compliance catching up, not a change of policy. release_train stays FALSE. caller-drift.py:562 verifies that field against release-train/repos.yml, so flipping it before the repos.yml entry lands would fail the guard. RFC-BACKEND-1552 D2 amends D1 to enrol the repo; the flip to true follows the repos.yml entry. The *no_workflows_directory_at_all anchor stays — devex-bootstrap still uses it. Verified: `python3 scripts/caller-drift.py --inventory repo-inventory.yml --source-dir .` exits 0, "No drift. Every repo read, every entry matched." across all 20 repos. Epic: tracebloc/backend#1552 RFC: tracebloc/rfcs#12 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
saadqbal
approved these changes
Aug 5, 2026
saadqbal
self-requested a review
August 5, 2026 14:34
Uh oh!
There was an error while loading. Please reload this page.
LukasWodka
commented
Aug 6, 2026
ContributorAuthor
FR on staging → Ready for prod (staging FR sweep, 2026-08-06). Basis: content-only change — merged and live on staging. No product-behavior verification required for this class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e-test-agent#13 added the
.github/workflowsdirectory that repo had lacked since 2026-06-03. So nineexemptentries inrepo-inventory.ymlnow assert the opposite of reality —exemptmeans the caller must be absent, and all nine are present.This is time-sensitive. The last
caller-driftrun was 13:53 UTC; #13 merged at 14:13. Left alone, the next scheduled run goes red for a gap that has just been closed.Why this block mattered
It was the largest single-repo block of
UNREMEDIATEDexemptions in the file — 11 of the 21 org-wide, where the next worst repo has 3. And the harm the exemptions recorded was real, not hypothetical: no issue or PR in that repo had ever reached the board, which is why e2e-test-agent#11 sat open and unreviewed for seven days.RFC-BACKEND-1405 D1 always required this — "Exempt never means ungoverned: every repo keeps branch protection, the code-quality caller and kanban auto-add." This is compliance catching up, not a change of policy.
The flip
To the private-train-repo template, identical to
frontend-app:advance-deploy-env/code-quality/customer-priority-bump/fr-gate/fr-pass-comment/kanban-closure-router/set-pr-statuspublic-pii-gate*private_repo_no_public_exposurewip-limit-check*wip_limit_check_has_no_callersadd-to-kanban,stale-backlog(copies)release_traindeliberately staysfalsecaller-drift.py:562verifies that field againstrelease-train/repos.yml, so flipping it before therepos.ymlentry lands would fail the guard. rfcs#12 D2 amends 1405 D1 to enrol the repo; the flip totruefollows therepos.ymlentry in a separate PR, not this one.The
*no_workflows_directory_at_allanchor stays —devex-bootstrapstill uses it.Verification
Ran the guard locally against live reality, not just a schema check:
Exit
0.Epic: tracebloc/backend#1552 · RFC: tracebloc/rfcs#12
🤖 Generated with Claude Code
Note
Low Risk
YAML-only inventory alignment with deployed workflows; no runtime or auth changes, and release_train is explicitly unchanged.
Overview
Updates
e2e-test-agentinrepo-inventory.ymlso the inventory matches the repo after e2e-test-agent#13 added.github/workflows. Nine UNREMEDIATEDexemptentries that claimed callers must be absent are flipped torequiredfor the standard private-repo callers and kanban copy workflows, aligned withfrontend-app.public-pii-gateandwip-limit-checkstay exempt but now cite the shared anchors (*private_repo_no_public_exposure,*wip_limit_check_has_no_callers) instead of the old “no workflows directory” text.add-to-kanbanandstale-backlogcopies move from*no_workflows_directory_at_alltorequired.Adds a block comment documenting the remediation, RFC-BACKEND-1405 compliance, and that
release_train: falseis intentional untilrelease-train/repos.ymllists the repo (guard checks that field).Reviewed by Cursor Bugbot for commit 2f5339c. Bugbot is set up for automated code reviews on this repo. Configure here.