Uh oh!
There was an error while loading. Please reload this page.
chore(priority-bump): remove the dead inputs, describe what it actually does (backend#1597) - #164
Merged
Merged
Conversation
…ly does (backend#1597) project-number, org and target-priority were declared and never read; the step hard-codes the 'priority' label per D5. Measured all 16 callers on develop and prod branches: byte-identical, secrets: inherit only, no with: blocks - so outright removal breaks nothing. trigger-label stays (used in the job if:). Header comment now describes the actual behavior: trigger label in, binary 'priority' issue label out, no board field. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 2 of tracebloc/backend#1597 (source finding: backend#1408 P3 —
customer-priority-bump.yml:9-20has three dead inputs and the step at:37hard-codes theprioritylabel while the org docs still sayPriority = P1).What was dead
Three of the four
workflow_callinputs were declared with defaults and never referenced anywhere in the file:project-number2orgtracebloctarget-priority"P1"--add-label priority; removedtrigger-labelfrom:customerif:) — kept, unchangedThey are leftovers from the pre-D5 design that wrote the board's
Priorityfield. Under D5 the workflow adds a binarypriorityissue label instead, and the Priority single-select no longer exists on the board (verified against project 2's live fields: Status / Work Type / Deploy environment / Area only). Removal over wiring: making the label name configurable would be redesign, and the ticket asks for cleanup.The header comment now states exactly what the workflow does — trigger label in (default
from:customer), binaryprioritylabel out, no board field written — so the file no longer needs its inputs block to be read sceptically. Deliberately not described as "sets Priority=P1 on the kanban card": that is the stale side of the #1408 doc-alignment finding. The org CLAUDE.md workflow table still saysPriority = P1and needs a docs-side fix outside this repo;repo-inventory.yml'scustomer_priority_bump_caller_missingnote can drop its dead-inputs clause once this is promoted.Caller-payload measurement (why outright removal is safe)
Removing an input a caller still passes would fail the call, so every caller was measured first: all 16 repos with a
customer-priority-bump.ymlcaller (averaging-service, backend, claude-skills, cli, client, client-runtime, data-ingestors, design-system, docs, e2e-test-agent, frontend-app, model-zoo, start-training, tracebloc-engine, tracebloc-py-package, tracebloc-website), each read on bothdevelopand its prod branch (main/master). All 32 copies are byte-identical (sha1 prefixa04b231c):uses: …@main+secrets: inherit, zerowith:blocks. No caller passes any input, so the deprecated-no-op fallback is unnecessary and nothing can break — including at@mainpromotion time, since callers pin@mainand prod-branch callers are the same bytes.Behavior unchanged
github.event.label.name == inputs.trigger-label, defaultfrom:customer.gh issue edit "$ISSUE_NUMBER" --add-label priorityunderPROJECTS_KANBAN_TOKEN.run:step and job are byte-for-byte untouched; only the header comment and the three unused input declarations changed.actionlintpasses.Part of tracebloc/backend#1597
🤖 Generated with Claude Code
Note
Low Risk
Documentation and dead-input removal only; trigger logic and the priority label step are unchanged and callers pass no removed inputs.
Overview
Cleans up the reusable customer priority bump workflow by dropping three unused
workflow_callinputs (project-number,org,target-priority) left over from when the flow wrote a kanban Priority field. Onlytrigger-labelremains (defaultfrom:customer).The top-of-file comment now documents the real behavior under D5: when the trigger label is added, the job adds the binary
priorityissue label and does not set any project board field. Thegh issue edit --add-label prioritystep and job conditions are unchanged; callers that usesecrets: inheritwith nowith:block are unaffected.Reviewed by Cursor Bugbot for commit de786b7. Bugbot is set up for automated code reviews on this repo. Configure here.