Skip to content

sec(ci)+fix(reconcile): SHA-pin pii-gate selftest + North Stars shield skips CLOSED issues (.github#166) - #167

Merged
LukasWodka merged 2 commits into
developfrom
fix/1491-selftest-pins-and-shield-state
Aug 6, 2026
Merged

sec(ci)+fix(reconcile): SHA-pin pii-gate selftest + North Stars shield skips CLOSED issues (.github#166)#167
LukasWodka merged 2 commits into
developfrom
fix/1491-selftest-pins-and-shield-state

Conversation

@LukasWodka

@LukasWodkaLukasWodka commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Two Bugbot findings from the develop→staging hop (.github mirror #166):

Mediumpublic-pii-gate-selftest.yml used floating actions/checkout@v4 / actions/setup-python@v5 while every other workflow SHA-pins (backend#1491 D10), and this repo runs no code-quality caller to catch it. Pinned to the same SHAs used repo-wide.

Low — the North Stars keep-open shield (kanban-reconcile.yml) filtered on status + type but not issue state, so CLOSED North Stars issues also got keep-open — an unnecessary, sticky, human-removal-only label the same run's classify step may terminalize. Now skips state == CLOSED.

Found 2026-08-06 staging hop.


Note

Low Risk
Workflow-only changes: action pinning and a narrower label condition with no auth or application runtime impact.

Overview
CI supply-chain:public-pii-gate-selftest.yml now pins actions/checkout and actions/setup-python to the same commit SHAs used elsewhere in the repo, replacing floating @v4 / @v5 tags.

Kanban reconcile: The North Stars stale-sweep shield only ensures keep-open on open issues in that column. Closed North Stars issues are skipped so the job does not add a sticky label that classify may terminalize in the same run (.github#166).

Reviewed by Cursor Bugbot for commit f1306b6. Bugbot is set up for automated code reviews on this repo. Configure here.

…end#1491, D10)
The new selftest workflow used floating @v4/@v5 while every other workflow here
pins to a 40-char SHA; this repo runs no code-quality caller to catch the drift.
…bot .github#166)
The shield filtered on status+type but not issue state, so closed North Stars
issues got a sticky keep-open the classify step may then terminalize.
@LukasWodka
LukasWodka merged commit 9e31981 into developAug 6, 2026
5 of 8 checks passed
@LukasWodka
LukasWodka deleted the fix/1491-selftest-pins-and-shield-state branch August 14, 2026 13:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@LukasWodka@saadqbal