Uh oh!
There was an error while loading. Please reload this page.
ci: arm action-pins on this repo now that #159 has promoted to main (backend#1603 step 2) - #178
Merged
Merged
Conversation
…backend#1603 step 2) The second half of backend#1603. When code-quality-caller.yml landed in #171 it could not arm action-pins: the job and its two inputs were added in #159 and existed on `develop` only, and a caller must reference @main (Q3). Passing an input the @main callee does not declare kills the entire reusable call with a startup_failure - not the one job, the whole call - measured on that branch's first push, run 31086491251. #159 has since promoted, and `main` now carries the six-job version with both inputs. Verified against the @main copy before flipping, rather than assuming the promotion carried what it looks like it carried. Hard-armed rather than left to inherit soft-fail. This is the check whose absence let .github#168 revert actions/checkout from a pinned commit SHA to the mutable @v4 tag with nothing in CI to object - in advance-deploy-env.yml, the most-consumed reusable workflow in the org, running with PROJECTS_KANBAN_TOKEN in scope. Every other repo consumes these workflows at @main and inherits whatever refs they pin, so this repo has a specific duty to enforce the rule it publishes. Re-measured the tree before arming: 24 `uses:` refs across 23 workflows, zero violations. Arming imports no backlog.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes backend#1603.
What changed and why it could not be done sooner
#171 gave this repo the org's own quality suite but had to leave
action-pinsoff, because the job and its two inputs were added in #159 and existed ondeveloponly — while a caller must reference@main(Q3). Passing an input the@maincallee does not declare kills the entire reusable call with astartup_failure, not just the one job. Measured on that branch's first push, run 31086491251: every other check reported normally andCode qualitynever started.#159has since promoted. I verified the@maincopy directly rather than assuming the promotion carried what it looks like it carried:Hard-armed, deliberately
action-pins-soft-fail: falserather than inheriting the soft-fail default. This is the specific check whose absence let #168 revertactions/checkoutfrom a pinned commit SHA to the mutable@v4tag with nothing in CI to object — inadvance-deploy-env.yml, the most-consumed reusable workflow in the org, running withPROJECTS_KANBAN_TOKENin scope. A human reading the diff caught it, which is the review path D10 exists to stop depending on.Every other repo consumes these workflows at
@mainand inherits whatever refs they pin, so this repo has a specific duty to enforce the rule it publishes.Arming imports no backlog
Re-measured immediately before flipping: 24
uses:refs across 23 workflows, zero violations. Expectquality / action-pinsgreen on this PR.Also confirmed live elsewhere:
quality / action-pinsnow reports on frontend-app PRs, so the promoted job is genuinely running fleet-wide rather than only existing on paper.Parent backend#1405.
Note
Low Risk
Workflow-only change that tightens CI; no runtime app, auth, or data-path changes.
Overview
Turns on the reusable workflow’s action-pins job for this repo by passing
action-pins: trueandaction-pins-soft-fail: falsefromcode-quality-caller.yml, replacing the prior comment block that deferred arming until#159was on@main.PRs here will now fail CI on unpinned third-party
uses:refs (org@mainreusables stay allowed), so the org workflow publisher enforces the same pin rule it ships to other repos.Reviewed by Cursor Bugbot for commit 38578ff. Bugbot is set up for automated code reviews on this repo. Configure here.