Uh oh!
There was an error while loading. Please reload this page.
release-train: develop -> staging - #184
Merged
Merged
Conversation
…-repo default reviewer @saqlainsyed007 raised both on the sync PRs (backend#1611, averaging-service#308), and both are source-side: the block must not be hand-edited in a consuming repo. 1. The block opened with an H1 while every consuming CLAUDE.md already has '# CLAUDE.md' as its sole title. Two H1s break the outline and trip markdownlint MD025. Every heading is demoted one level so the standards nest as a section under the host document's title. 2. 'Each repo's CLAUDE.md names its default reviewer' is false fleet-wide -- no repo names one -- and it contradicts the org's actual model, which is author-picks-reviewer with no automation assigning anyone. The line now describes what we really do, so the rule above it is actionable. Selftest: 20 checks, 0 failed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Removes this repo's caller for the public PII gate. Lukas's decision, 2026-08-06: retire the gate for now rather than leave it in place undeployed. WHY. The gate has never had a denylist. PII_DENYLIST does not exist as an org Actions secret and never has, so the workflow correctly failed closed on every PR - "an inactive guard must be visible as red, not invisible as green", as its own header puts it. Applied to a secret that was never provisioned, that produced a permanent red across all 7 public repos which blocked nothing: 24 open PRs carried it, and the whole org - this author included - had learned to filter it out. A check that is red on every PR is not fail-closed; it is off with extra steps, and it would be indistinguishable from noise on the day it went red for a real reason. WHAT LAPSES, stated plainly. The gate grepped PR title + body + every commit message against a private list of customer/partner names, on public repos only. It never read code, diffs or filenames, and detected no PII patterns - secrets in code remain gitleaks' job. So what lapses is the mechanical backstop for CLAUDE.md's rule that internal work and customer mentions never go in a public repo. That rule still stands and is now enforced by review alone. The reusable workflow and its selftest stay in tracebloc/.github, dormant with no callers. Restoring is three steps: set the org secret, restore this file, flip the inventory entry back to required. Checklist and the denylist-content caveat are on backend#1409. Not required on any branch, so this removes no merge gate.
…d-reviewer-claim docs(standards): fix the block's H1 and the false default-reviewer claim (backend#1602)
…409) (#183) Completes the retirement Lukas decided on 2026-08-06. The 7 callers were removed first (cli#466, client#638, docs#96, data-ingestors#462, model-zoo#130, start-training#44, .github#182, all merged); this drops the reusable from the inventory so the contract matches reality. ORDERING MATTERS AND WAS NOT INCIDENTAL. The audit reads the inventory from the checkout but every repo's state over the API, so callers and inventory cannot change in one commit - the docstring says as much for the ADD direction, and the remove direction has the same hazard inverted. Callers first, then this. In between, the audit would have reported "MISSING required caller" for 7 repos; that window is now closed. Verified before pushing by running caller-drift.py locally against the live fleet: "20 repos x 8 reusables + 2 copies. Audited 20 of 20. No drift." Removed: - public-pii-gate.yml from the `reusables` list - all 20 per-repo `callers` entries for it (7 required, 13 exempt) - the `private_repo_no_public_exposure` shared reason, now referenced by nothing - the stale claim in the MATCHING header that public-pii-gate uses the `-caller.yml` convention; it no longer has callers to have a convention The .github entry's long red-inert explanation is replaced by a short retirement note rather than deleted outright: WHY a guard was withdrawn is the part a future reader needs, and it is the only place that records that the denylist never existed. The reusable workflow and its selftest stay in this repo, dormant with no callers, so restoring is three steps rather than a rebuild.
LukasWodka
commented
Aug 6, 2026
ContributorAuthor
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 4ba316a. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated promotion by the release train (RFC-0008 D14). Head is the train-managed
release-train/to-stagingbranch (a mirror ofdevelop), so it never collides with a human PR. Merged only when the fr-gate is green.Note
Medium Risk
Touches the canonical caller-drift inventory and removes a PII-scanning gate from public repos, reducing automated PR metadata checks until an alternative exists.
Overview
Retires the org-wide
public-pii-gateCI integration (backend#1409): removes the.githubrepo’spublic-pii-gate-caller.ymland stripspublic-pii-gate.ymlfromrepo-inventory.yml—including thereusableslist, every per-reporequired/exemptentry, and theprivate_repo_no_public_exposureshared reason. Inventory comments document that the reusable stays in the repo dormant with no callers until a denylist secret exists and callers are restored.Updates
org-standards.mdto use###section headings instead of##, and clarifies PR review: authors pick a reviewer (no per-repo default or auto-assignment); merge still requires a human review via branch protection.Reviewed by Cursor Bugbot for commit 4ba316a. Bugbot is set up for automated code reviews on this repo. Configure here.