Uh oh!
There was an error while loading. Please reload this page.
docs: drop the retired PII gate from secrets guidance - #192
Merged
Conversation
saadqbal
approved these changes
Aug 10, 2026
Uh oh!
There was an error while loading. Please reload this page.
LukasWodka added a commit
that referenced
this pull request
Aug 26, 2026
…s live client-runtime#192 was closed unmerged at 08:26 today, which the citation guard caught. Reading the sentence caught the other half: client#490 had already merged. "two live PRs go red the moment it is on" described the fleet at writing time and nothing since. Restated in the past tense, and the citation kept -- the reason now records that #192 was closed rather than leaning on it landing, so the deadness is the content. EXEMPT carries that rationale and says when to delete it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
LukasWodka added a commit
that referenced
this pull request
Aug 26, 2026
…appened (#342) * fix(2516,2517): two reasons that describe something other than what happened Both deferred from the .github#334 staging hop under the severity policy, both verified against source before fixing. 2516 -- claude-skills fr-gate. The reason framed the caller absence as the audit DISCOVERING a missing caller, and ended "if the caller was removed by mistake, restore it and flip this back". It was not a mistake: claude-skills#38 deleted fr-gate-caller.yml on purpose (+0/-15) as the remainder of backend#2347, because this repo does not ride the train. The remedy does not run both ways and the reason no longer says it does. 2517 -- the rfcs prod cell claimed reason-citations.py "can at least check that a cited issue is still open" while naming backend#2501 only in a YAML comment, which that script never reads. The claim is now the opposite and says why moving the citation into a scanned string is NOT the fix: the only reason-bearing field there is an alias to a shared anchor. The citation guard then caught this change: the new 2516 text cites backend#2347, which is CLOSED. That is the guard working, so #2347 is EXEMPTed with what it is doing there rather than reworded out to silence it. Also folded in, because repo-inventory.yml is a GUARDED file and two PRs cannot both hold a green audit on their own SHA: the five bugbot-gate rows whose callers merged today. The anchor stops enumerating repos -- that list went stale twice and is now derived. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ci(2284): the four callers that merged at 07:46 get their rows too Folded onto this PR rather than opened separately: repo-inventory.yml is a GUARDED file needing a green org audit on its own SHA, and callers kept landing while this sat unmerged. Two PRs racing for that green is a deadlock, not a queue. averaging-service, data-ingestors, tracebloc-engine and tracebloc-py-package all merged at 07:46. 19 of 20 rows are now `required`; design-system-v2 is the only one left, and its caller PR is held by a pre-existing Code Connect failure on that repo (backend#2523), not by anything in the rollout. This PR had already passed `audit` -- before those four merged. That green was stale the moment they landed, which is the re-run trap the release-train README documents, one layer out. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix: a PR must not cite the issue it closes in a SCANNED string (Bugbot High) The rewritten claude-skills fr-gate reason cited backend#2516 inside an `exempt:` string -- and this PR closes backend#2516. reason-citations.py would then see a citation to a CLOSED issue on every subsequent PR and fail the required selftests job fleet-wide. It could not be pre-EXEMPTed either, because the issue is open until this merges, and an EXEMPT row for a live issue is itself a stale exemption. A self-inflicted trap and a good catch: the citation now names the hop (.github#334) rather than the ticket the merge closes. Also -- the folded scalar lost its indentation AGAIN, from my own edit that removed the stale enumeration. Three continuation lines sat two spaces deeper than the block base, so they stopped folding and injected literal newlines into every repo aliasing the reason. Second time today. Verified this time by loading the file and reading the rendered value rather than by reading the diff, which looked fine both times. And the splice that removed the enumeration had duplicated the claude-skills#36 parenthetical. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(inventory): the blocked-gate reason named two live PRs; neither is live client-runtime#192 was closed unmerged at 08:26 today, which the citation guard caught. Reading the sentence caught the other half: client#490 had already merged. "two live PRs go red the moment it is on" described the fleet at writing time and nothing since. Restated in the past tense, and the citation kept -- the reason now records that #192 was closed rather than leaning on it landing, so the deadness is the content. EXEMPT carries that rationale and says when to delete it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The public PII gate is retired org-wide (backend#1409, #188). This CLAUDE.md line still claimed it provides secret-scanning protection, so Bugbot flags "PII gate is removed without replacement" as a High on every promotion hop (it held model-zoo on 2026-08-10). Drops the stale reference; gitleaks remains the secret scanner.
Doc-only, one line. Part of finishing the PII-gate removal cleanly.
Note
Low Risk
Single-line documentation change with no runtime, security-control, or data-handling impact.
Overview
Updates the org-wide Quality bar secrets bullet in
CLAUDE.mdso it no longer names the retired PII gate alongside gitleaks — only gitleaks is cited as the scanner that will catch committed secrets.This aligns the managed org-standards text with org-wide PII-gate retirement and avoids Bugbot treating the stale reference as a missing control on promotion PRs.
Reviewed by Cursor Bugbot for commit 1e14412. Bugbot is set up for automated code reviews on this repo. Configure here.