Uh oh!
There was an error while loading. Please reload this page.
fix(kanban): fail closed when projectItems truncation could hide the kanban card (#190) - #193
Merged
Conversation
…kanban card Bugbot .github#190 (Medium). The projectItems totalCount>20 guard only warned, so if an issue is on >20 projects and its engineering-kanban card sits beyond the first 20 we fetch, ITEM_ID comes back empty and the card is silently skipped as "not on project" while the run stays green — the exact silent-skip the guard was meant to close (the sibling closingIssuesReferences guard already fails closed). Move the truncation check into the not-found branch and set RUN_FAILED there: we only fail when the card was actually not found AND the list was truncated (pi_total>20), so a normal issue-on-<=20-projects still skips cleanly with no false failures. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
saadqbal
approved these changes
Aug 10, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bugbot #190 (Medium). The
projectItemstotalCount>20guard inadvance-deploy-env.ymlonly warned — unlike its siblingclosingIssuesReferencesguard, which setsRUN_FAILED. So if an issue is on >20 projects and its engineering-kanban card is beyond the first 20 we fetch,ITEM_IDis empty, the card is skipped as "not on project", and the run stays green — the silent-skip this guard was meant to close.Fix
Moved the truncation check into the not-found branch and set
RUN_FAILEDthere. We fail only when the card was actually not found AND the list was truncated (pi_total>20). A normal issue on <=20 projects still skips cleanly — no false failures (avoids the over-fail of an unconditional guard).Closes the last fail-open in the drift-fix code (companion to #181).
Note
Low Risk
Workflow-only change to error handling when GraphQL
projectItemsis truncated; no app runtime or auth impact.Overview
Closes a fail-open path in
advance-deploy-env.ymlwhen advancing closed issues linked to promoted PRs: if an issue’s engineering-kanban card isn’t in the first 20projectItemsreturned, the step used to treat it as “not on project” and keep the run green.The
pi_total > 20guard is moved into the missingITEM_IDbranch and setsRUN_FAILED, matching the siblingclosingIssuesReferencestruncation behavior. Issues on ≤20 projects still skip cleanly when they’re genuinely not on the project; only not-found + truncated list fails the run so a possibly lagging card isn’t silently ignored.Reviewed by Cursor Bugbot for commit b15af8f. Bugbot is set up for automated code reviews on this repo. Configure here.