Skip to content

fix(ci): rename 'In review' → 'Code review' in set-pr-status workflow - #20

Merged
LukasWodka merged 1 commit into
developfrom
fix/rename-in-review-status
Apr 29, 2026
Merged

fix(ci): rename 'In review' → 'Code review' in set-pr-status workflow#20
LukasWodka merged 1 commit into
developfrom
fix/rename-in-review-status

Conversation

@LukasWodka

Copy link
Copy Markdown
Contributor

Status options renamed today for clarity:

  • In reviewCode review
  • ValidationFunctional review

The set-pr-status reusable workflow looks up the Status option by name when setting it on PR open. Updating the hardcoded reference to match the new name.

advance-deploy-env, kanban-closure-router, and the cron auto-classifier reference Done / Cancelled (unchanged) — no update needed there.

🤖 Generated with Claude Code

The Status column was renamed today for clarity (In review → Code review,
Validation → Functional review). The set-pr-status reusable workflow
looked up the Status option by name, so its hardcoded reference needs to
match the new name.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@LukasWodka
LukasWodka merged commit 7dbaabf into developApr 29, 2026
@LukasWodka
LukasWodka deleted the fix/rename-in-review-status branch April 29, 2026 11:34
@LukasWodkaLukasWodka added bug Something isn't working work-type:bug Defect or regression labels Jun 8, 2026
LukasWodka added a commit that referenced this pull request Aug 27, 2026
#362)
set-pr-status.yml's header said the non-draft card moves to "In review". That
option was renamed "In review" -> "Code review" in #20 (7dbaabf) and no longer
exists on the board -- verified against the live Status field, whose options are
Backlog, North Stars, Ready, In progress, Code review, On dev, Staging (agent
review), FR on staging, Ready for prod, Prod, Done, Cancelled.
The code has been correct throughout: the job writes `status_name=Code review`
(:108), and the same header already says "the SAME event that puts a card in
`Code review`" thirty lines further down. So the file disagreed with itself, and
the wrong half is the part a reader meets first.
Comment-only. No workflow logic, no behaviour change.
Swept the repo for the same phrasing; this was the only board reference. Two
other matches are deliberately left alone: repo-inventory.yml:635 uses "while
this PR was in review" to mean review as an activity, which is correct English
and not a column name, and standards-sync-selftest.py:428 is a Python `in`
operator, not the phrase.
make check: 95 passed 0 failed, 29 passed 0 failed, EXIT=0.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workingwork-type:bugDefect or regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@LukasWodka@saadqbal