Uh oh!
There was an error while loading. Please reload this page.
docs(inventory): the contract denied an action-pins gate that is armed (backend#1668) - #215
Merged
Merged
Conversation
…d (backend#1668) `.github`'s own entry said "action-pins itself stays unarmed until #159 reaches main". #159 reached main and action-pins was armed on 2026-08-06 (backend#1603 step 2), but the line was never updated -- so the single source of truth denied a control the repo actually has. Measured on origin/develop: this repo's `code-quality-caller.yml` passes `action-pins: true` + `action-pins-soft-fail: false`, and `quality / action-pins` is a REQUIRED status check on develop. The original caveat is kept rather than deleted, because it explains WHY arming had to wait: a caller may only pass inputs the @main callee declares, or the whole call dies with startup_failure. Comment-only; selftest re-run: 97 pass, 0 fail. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
saadqbal
approved these changes
Aug 11, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Finding 3 of backend#1668 — "Inventory denies armed action-pins".
.github's own entry inrepo-inventory.ymlsaid:#159 reached main and action-pins was armed on 2026-08-06 (backend#1603 step 2), but that line was never updated. So the single source of truth denied a control the repo actually has — the exact class of staleness this file exists to eliminate.
Verified on origin/develop
.github/workflows/code-quality-caller.ymlpassesaction-pins: trueandaction-pins-soft-fail: falsequality / action-pinsis a required status check on.github/developKept, not deleted
The original caveat stays, because it explains why arming had to wait: a caller may only pass inputs the
@maincallee declares, or the whole call dies withstartup_failure.Comment-only. Selftest re-run: 97 pass, 0 fail.
Parent epic: backend#1680.
Note
Low Risk
Documentation-only change to repo-inventory.yml comments; no workflow or enforcement behavior changes.
Overview
Updates the
.githubcode-quality.ymlblock inrepo-inventory.ymlso the contract matches what CI already does.The old note said action-pins stays unarmed until #159 reaches main; that was never revised after 2026-08-06 arming (backend#1603), even though the caller enables
action-pins: truewithaction-pins-soft-fail: falseandquality / action-pinsis required on develop. The edit records that mismatch (backend#1668) and keeps the startup_failure caveat: callers can only pass inputs the @main callee declares.Reviewed by Cursor Bugbot for commit e734352. Bugbot is set up for automated code reviews on this repo. Configure here.