Uh oh!
There was an error while loading. Please reload this page.
docs(inventory): the three promotion cells in design-system-v2 say which case they are - #343
Conversation
…ase they are Bugbot Medium, deferred from the .github#334 staging hop. The block was created 2026-08-25 by copying ON-TRAIN design-system, so all three promotion-shaped rows arrived `required` while every other off-train repo exempts version-bump and fr-gate. The rows were UNEXPLAINED rather than wrong -- and measured 2026-08-26, the three are not the same case at all: version-bump-gate branches: [develop] -- ACTIVE on every PR here fr-gate branches: [staging, main, master] -- NONE exist, dormant fr-pass-comment issue_comment, no branch filter -- CAN fire, on a repo with no `FR on staging` card to advance All three stay `required` because all three callers EXIST, and an exempt row whose caller is present is the stale-exemption finding at caller-drift.py:2309 -- flipping them would trade an unexplained row for a red audit. Exempting means deleting the callers first, which is an onboarding decision and stays open on backend#2512. Comment-only: no cell value changes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
saqlainsyed007
left a comment
There was a problem hiding this comment.
Docs-only, and correct. This adds explanatory comments to the design-system-v2 promotion cells without flipping any required/exempt row — documenting that the block was copied from on-train design-system (so all three promotion callers arrived required), and that in this off-train, develop-only repo the three behave differently: version-bump-gate is active on every PR, fr-gate is permanently dormant (no staging/main/master branch to trigger on), and fr-pass-comment can actually fire on issue_comment. The reasoning for keeping them required is sound — an exempt row whose caller is still present is itself the stale-exemption finding, so exempting means deleting the callers first (the onboarding half of backend#2512), and you correctly leave the fr-pass-comment question open rather than settling it here. No overclaiming; nothing to change in the content.
Not approving yet only on the green gate: audit/gate are red, but not because of this PR — the audit reports fleet-wide caller-inventory drift ("9 drift finding(s), every one with a PR open — fixed-pending-merge, NOT yet conformant"), which a comments-only change neither causes nor fixes. Once the fleet remediation PRs land and the audit goes green, this is an approve.
saqlainsyed007
left a comment
There was a problem hiding this comment.
Approving fe0a1dd. The fleet audit that was reddening this is now green — the dead citation cleared once #342 landed on develop (merged into this branch), so the only thing that was ever holding it is resolved. The PR's own content is unchanged and still correct: docs-only comments on the design-system-v2 promotion cells, documenting that version-bump-gate is active, fr-gate is dormant (no staging/main branch), and fr-pass-comment can misfire, and why all three stay required (an exempt row whose caller exists is itself the stale-exemption finding). CI green, no open threads. LGTM.
Uh oh!
There was an error while loading. Please reload this page.
Closes tracebloc/backend#2512
Bugbot Medium, deferred from the
.github#334staging hop under the severity policy.The finding is right, and the three cells are not the same case
The block was created 2026-08-25 by copying on-train
design-system, so all three promotion-shaped rows arrivedrequiredwhile every other off-train repo exempts version-bump and fr-gate:claude-skillsdesign-system-v2release-trainrfcsdesign-systemBut "flip them to match the siblings" is the wrong remedy, because measured 2026-08-26 the three behave completely differently in a repo whose only branch is
develop:version-bump-gatebranches: [develop]fr-gatebranches: [staging, main, master]fr-pass-commentissue_comment, no branch filter/fr-passtyped here reaches the reusable, in a repo with noFR on stagingcard to advanceSo one is correct as-is, one is inert, and one is a live misfire path. A single blanket flip would have been wrong on two of the three.
Why they stay
requiredAll three callers exist in the repo. An
exemptrow whose caller is present is the stale-exemption finding (caller-drift.py:2309), so flipping would trade an unexplained row for a red audit.Exempting them properly means deleting the callers first — caller first, entry after, the same order
claude-skills#38used. That is an onboarding decision, not a bookkeeping edit, and it is the part of #2512 this PR deliberately does not settle.What this PR does
Comment-only — zero cell values change (
git diffnon-comment added lines: 0). It converts three unexplained rows into three rows that say which case they are, which is exactly what the finding asked for: "the caller block matches on-traindesign-system, not those siblings", with no per-cell reason to explain it.The
fr-pass-commentnote also records the sibling split Bugbot flagged:release-trainkeeps itrequiredwhile exempting the other two, and that is deliberate there because the train's own cards do get functionally reviewed. Whether that reasoning transfers to a component library nobody promotes is left open rather than assumed.Left open on #2512, deliberately
Does
design-system-v2join the release train? It was created yesterday, publishes privately to GitHub Packages, has an active parity epic (design-system-v2#10), and has nomainand nostaging. It reads as mid-onboarding rather than permanently off-train — but nothing states which, and that decision determines whether the three callers are deleted or the branches are created.Two other things surfaced while measuring, neither in scope here:
design-system-v2/develophas no branch protection at all — no classic protection, no rulesets.Code Connect (Figma)fails ondevelopand therefore on every PR — pre-existing, tracked in backend#2523, and not this repo's workflow set.Note
Low Risk
Inventory documentation only; no contract values, workflows, or protection settings change.
Overview
Comment-only update to
repo-inventory.ymlfordesign-system-v2: no caller cell values change (requiredstays as-is).Adds audit-trail comments for the three promotion-shaped rows (
version-bump-gate,fr-gate,fr-pass-comment) that were copied from on-traindesign-systemwhile other off-train repos exempt two of them. The text explains why they are not the same case on a develop-only repo: version-bump is active on every PR;fr-gateis dormant (no staging/main/master);fr-pass-commentcan still run on/fr-passwithout a branch filter.It also records why flipping them to
exemptto match siblings would be wrong without removing the workflows first (present caller +exempt= stale-exemption drift), and leaves the onboarding decision (train vs delete callers) open on backend#2512.Reviewed by Cursor Bugbot for commit fe0a1dd. Bugbot is set up for automated code reviews on this repo. Configure here.