Uh oh!
There was an error while loading. Please reload this page.
fix(codeowners): make the code-owner requirement on this repo real - #69
Merged
Merged
Conversation
`main` has had `require_code_owner_reviews: true` since branch protection was applied, but this repository has never contained a CODEOWNERS file — so the requirement resolved to nothing and any two of the seven org members could change the gates themselves with one approval and no CI. That matters more here than anywhere else. 96 caller workflows across 14 repos pin `tracebloc/.github/.github/workflows/*.yml@main`, and all of them pass `secrets: inherit`, so a single merge to this repo takes effect org-wide on the next workflow run and reaches every secret the calling repos hold. Adds @LukasWodka as owner of the workflows, the scripts they call, and the repository by default. This does not change the self-merge path: as sole owner he cannot approve his own PRs and still relies on `enforce_admins: false`. The control added here is over the other six members' changes to the enforcement layer.
LukasWodka
commented
Jul 25, 2026
ContributorAuthor
👋 Heads-up — Code review queue is at 42 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
LukasWodka
commented
Jul 26, 2026
ContributorAuthor
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f7cd9fb. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
tracebloc/.githubis the org's enforcement root. 96 caller workflows across 14 repos pintracebloc/.github/.github/workflows/*.yml@main, and every one passessecrets: inherit— so asingle merge here takes effect everywhere on the next workflow run and reaches every secret the
calling repos hold:
PROJECTS_KANBAN_TOKEN,DOCKERHUB_TOKEN,PYPI_API_TOKEN,HF_TOKEN,GH_PACKAGES_TOKEN,TEST_USER_PASSWORD, the Azure publish profiles.It is also the least protected repo in the org:
mainrequire_code_owner_reviewstrue— but no CODEOWNERS file existed, so it resolved to nothingenforce_adminsfalsemainin the last 90 days with zero approving reviewsSo the gate that guards every other gate could be changed by any two of the seven org members.
What this does
Adds a CODEOWNERS file naming
@LukasWodkafor the workflows, the scripts they invoke, and therepository by default. The
require_code_owner_reviewsflag already set onmainstarts resolvingto an actual person.
What it deliberately does not do
It does not close the self-merge path. As sole code owner, @LukasWodka cannot approve his own
PRs, so his changes still depend on
enforce_admins: false. That is a conscious trade: the controladded here is over the other six members' changes to the enforcement layer. Naming a second owner
would make it a genuine two-person rule at the cost of a second gatekeeper — worth deciding
separately.
Still open on this repo
required on
mainonce merged.secrets: inheriton all 96 callers should be narrowed to the single secret each workflowactually needs. That is a cross-repo change, not this PR.
@main, a mutable ref. Pinning to a SHA or release tag would remove theinstant-propagation property entirely.
Context: RFC-BACKEND-0008 (tracebloc/backend#1262) D18/D19.
Note
Low Risk
Policy-only addition with no runtime or workflow logic changes; it strengthens merge governance on an already security-sensitive repo.
Overview
Adds a new
.github/CODEOWNERSsorequire_code_owner_reviewsonmainactually requires review from@LukasWodkafor the default tree,/.github/workflows/, and/scripts/.That tightens who can merge changes to the org’s shared reusable workflows and their scripts; the file documents why this repo matters and that sole-owner review does not block admin self-merge.
Reviewed by Cursor Bugbot for commit f7cd9fb. Bugbot is set up for automated code reviews on this repo. Configure here.