Uh oh!
There was an error while loading. Please reload this page.
fix(kanban): fr-pass author check, kill Release-title auto-promote, prod-branch probe, drop auto-classify - #76
Merged
Conversation
…ssify cron
Four solo .github hardening items from RFC-BACKEND-0008, all board-automation:
- D30 (#1271): /fr-pass must be a real second pair of eyes. Refuse when the
commenter is the PR author, and require MEMBER/OWNER (drop COLLABORATOR, which
includes read-only outside collaborators). The Functional-reviewer field was
set on 0 of 100 items; a self-pass was one comment away.
- D27-L4 (#1267a): remove the Release:-title auto-promote. A PR titled
'Release: anything' merged to develop made kanban-reconcile set Status=Prod —
rank 10, satisfying every future gate. Deleted; the drift-to-prod path (SHA
actually on the prod branch) is the sound mechanism and stays.
- D27-L4 (#1267b): resolve the prod branch by probing main/master, not by
reading a repo-controlled .kanban.yml from the default branch. A repo could
commit 'branch_status_map: {develop: Prod}' and self-grant prod status to
every develop merge. Ground truth now comes from the repo's branch list.
- D21 (#1279): delete auto-classify.yml. It ran every 10 min to populate Squad
(deleted by D4) and rewrite Deploy environment with junk values; it is also
what made updatedAt useless as a staleness signal. No callers.
actionlint + shellcheck clean; no dangling auto-classify references.
Refs tracebloc/backend#1271 #1267 #1279LukasWodka
commented
Jul 26, 2026
ContributorAuthor
bugbot run |
LukasWodka
commented
Jul 26, 2026
ContributorAuthor
👋 Heads-up — Code review queue is at 40 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a52a23b. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
LukasWodka
commented
Jul 26, 2026
ContributorAuthor
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a52a23b. Configure here.
This was referenced Jul 26, 2026
LukasWodka added a commit
that referenced
this pull request
Jul 26, 2026
.github hosts the reusable advance-deploy-env.yml (workflow_call only) but had no push-triggered caller of its own — the only repo without one — so its kanban items never advanced when code shipped: feature PRs stranded at 'FR on dev' while the promotion PR alone reached Prod. (This was meant to land in #76 but the commit was orphaned — pushed after #76 had already merged. Re-landing cleanly here.) Adds the same push-triggered caller the other 14 repos have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four solo
.githubboard-automation hardening items — all mergeable without colleague review./fr-passrefuses the PR author; requires MEMBER/OWNER (drops COLLABORATOR)Functional reviewerwas set on 0 of 100 items.Release:-title auto-promoteRelease: …merged to develop made reconcile setStatus=Prod(rank 10 → satisfies every gate). The drift-to-prod path (SHA actually on the prod branch) is the sound mechanism and stays.main/master, not a repo-controlled.kanban.ymlbranch_status_map: {develop: Prod}and self-grant prod status to every develop merge.auto-classify.ymlSquad(deleted by D4) and rewriteDeploy environmentwith junk values; also what madeupdatedAtuseless for archiving. No callers.actionlint + shellcheck clean; no dangling
auto-classifyreferences;yqdependency dropped from reconcile.Promote to
mainafter merge (callers read@main) — the/fr-passand reconcile changes only take effect once onmain.Note
Medium Risk
Changes gate who can advance kanban status and how reconcile auto-moves items to Prod; misconfiguration could block legitimate FR sign-offs or leave drift uncorrected until SHA-based promotion applies.
Overview
Hardens engineer kanban GitHub automation around who can advance FR and how items reach Prod.
/fr-passnow requires MEMBER or OWNER (no COLLABORATOR) and blocks the PR/issue author from signing off their own functional review.kanban-reconcileno longer auto-promotes merged PRs whose titles look like release vehicles; Prod moves rely on merge SHA on the prod branch only. Prod branch resolution probesmainthenmasterinstead of reading repo-controlled.kanban.yml, closing self-grant paths via branch map overrides.Removes the
auto-classify.ymlcron that synced Squad/Area and Deploy environment every 10 minutes.Reviewed by Cursor Bugbot for commit a52a23b. Bugbot is set up for automated code reviews on this repo. Configure here.