Uh oh!
There was an error while loading. Please reload this page.
fix(cli): advertise data ingest/data delete in runtime + help strings - #135
Merged
Conversation
…ings
Several user-facing printed and help strings still named the old
`dataset push` command, which was renamed to `data ingest` (old name
kept only as a deprecated alias). Update the strings a customer actually
sees to the canonical verbs:
- cluster info/doctor success line: "Ready for `tracebloc data ingest`."
- `cluster` Long help: next `data ingest` will target …
- `cluster info` Long help: jobs-manager Service the next data ingest
- `ingest validate` Long help: pre-flight before `tracebloc data ingest`
Left internal code comments (developer-facing, not printed) and the
alias-resolution tests untouched. `data_list.go`'s "emit the dataset
list as JSON" is descriptive ("the list of datasets"), not a command
reference, so it stays as-is.
Separate from the install-time messaging fixed in #134.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>LukasWodka
commented
Jul 6, 2026
ContributorAuthor
👋 Heads-up — Code review queue is at 35 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
saadqbal
approved these changes
Jul 6, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several user-facing printed/help strings still advertised the old
dataset pushcommand name, which was renamed todata ingest(the old name is retained only as a deprecated alias). This updates the strings a customer actually sees to the canonicaldata ingest/data delete.This is separate from the install-time messaging already fixed in #134.
Changes
internal/cli/cluster.gocluster info/cluster doctor)Ready for `tracebloc dataset push`.→Ready for `tracebloc data ingest`.internal/cli/cluster.goclusterLong helpdataset pushwill target → nextdata ingestwill targetinternal/cli/cluster.gocluster infoLong helpdataset push→data ingestinternal/cli/ingest.goingest validateLong helptracebloc dataset push→tracebloc data ingestDeliberately left as-is
dataset push(e.g.cluster.go:18,root.go:134, and comments underinternal/push/,internal/cluster/, etc.) — developer-facing, never printed.internal/cli/data_test.goalias-resolution test names ("dataset push alias resolves", "dataset rm alias resolves") — these deliberately assert the deprecated aliases still work.internal/cli/data_list.go:86("emit the dataset list as JSON") — reviewed and confirmed descriptive ("the list of datasets"), not a command reference.Test plan
go build ./...— cleango test ./internal/cli/...— passes (ok … 1.622s)🤖 Generated with Claude Code