Skip to content

fix(cli): advertise data ingest/data delete in runtime + help strings - #135

Merged
saadqbal merged 1 commit into
developfrom
ux/data-ingest-runtime-strings
Jul 6, 2026
Merged

fix(cli): advertise data ingest/data delete in runtime + help strings#135
saadqbal merged 1 commit into
developfrom
ux/data-ingest-runtime-strings

Conversation

@LukasWodka

Copy link
Copy Markdown
Contributor

Summary

Several user-facing printed/help strings still advertised the old dataset push command name, which was renamed to data ingest (the old name is retained only as a deprecated alias). This updates the strings a customer actually sees to the canonical data ingest / data delete.

This is separate from the install-time messaging already fixed in #134.

Changes

FileLocationBefore → After
internal/cli/cluster.gosuccess line (printed by cluster info/cluster doctor)Ready for `tracebloc dataset push`.Ready for `tracebloc data ingest`.
internal/cli/cluster.gocluster Long helpnext dataset push will target → next data ingest will target
internal/cli/cluster.gocluster info Long helpjobs-manager Service the next dataset pushdata ingest
internal/cli/ingest.goingest validate Long helppre-flight before tracebloc dataset pushtracebloc data ingest

Deliberately left as-is

  • Internal code comments referencing dataset push (e.g. cluster.go:18, root.go:134, and comments under internal/push/, internal/cluster/, etc.) — developer-facing, never printed.
  • internal/cli/data_test.go alias-resolution test names ("dataset push alias resolves", "dataset rm alias resolves") — these deliberately assert the deprecated aliases still work.
  • internal/cli/data_list.go:86 ("emit the dataset list as JSON") — reviewed and confirmed descriptive ("the list of datasets"), not a command reference.

Test plan

  • go build ./... — clean
  • go test ./internal/cli/... — passes (ok … 1.622s)

🤖 Generated with Claude Code

…ings
Several user-facing printed and help strings still named the old
`dataset push` command, which was renamed to `data ingest` (old name
kept only as a deprecated alias). Update the strings a customer actually
sees to the canonical verbs:
- cluster info/doctor success line: "Ready for `tracebloc data ingest`."
- `cluster` Long help: next `data ingest` will target …
- `cluster info` Long help: jobs-manager Service the next data ingest
- `ingest validate` Long help: pre-flight before `tracebloc data ingest`
Left internal code comments (developer-facing, not printed) and the
alias-resolution tests untouched. `data_list.go`'s "emit the dataset
list as JSON" is descriptive ("the list of datasets"), not a command
reference, so it stays as-is.
Separate from the install-time messaging fixed in #134.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@LukasWodka

Copy link
Copy Markdown
ContributorAuthor

👋 Heads-up — Code review queue is at 35 / 30

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

@saadqbal
saadqbal merged commit 03d5457 into developJul 6, 2026
17 checks passed
@LukasWodka
LukasWodka deleted the ux/data-ingest-runtime-strings branch July 9, 2026 11:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@LukasWodka@saadqbal