Uh oh!
There was an error while loading. Please reload this page.
feat(cli): sync ingest schema; wire sentence_pair_classification + embeddings - #163
Merged
Merged
Conversation
…beddings (#162) The Schema drift check (scripts/sync-schema.sh --check) was red on every open PR: internal/schema/ingest.v1.json had drifted from upstream tracebloc/data-ingestors@master, which added two task categories (sentence_pair_classification, embeddings), a content_hash data_id strategy, and description updates. - Re-vendor the current upstream schema (sync-schema.sh). - Add both new categories to categoryRegistry as FamilyText (they stage raw .txt from texts/, per data-ingestors conventions.py TEXT_CATEGORIES). - Mark both CLISupported: false with an UnsupportedNote, mirroring causal_language_modeling/seq2seq/token_classification, until the `tracebloc ingest` discover/build staging path for them is confirmed. (Flip to true if the push path already supports them.) - Update the pinned lists in category_registry_test.go. Fixes the registry⇄schema parity test (TestRegistryCoversSchemaCategories) that a bare schema sync would otherwise break. go build/vet/test green. Closes#162 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
aptracebloc
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears the failing Schema drift check that's red on every open PR (including #160).
internal/schema/ingest.v1.jsonhad drifted from upstreamtracebloc/data-ingestors@master, which added two task categories (sentence_pair_classification,embeddings), acontent_hashdata_idstrategy, and description updates. The drift predates and is unrelated to any in-flight feature — it was stale ondeveloptoo.What's in
scripts/sync-schema.sh.categoryRegistry(internal/push/category.go) asFamilyText— both stage raw.txtfromtexts/, matching data-ingestorsconventions.pyTEXT_CATEGORIES.CLISupported: falsewith anUnsupportedNote, mirroring howcausal_language_modeling/seq2seq/token_classificationwere added — conservative until thetracebloc ingestdiscover/build staging path for them is confirmed.category_registry_test.go.I defaulted both to not-yet-CLI-supported. If
dataset pushalready stages thetext_a\ttext_b(sentence-pair) andanchor\tpositive[\tnegative](embeddings)texts/layouts, flipCLISupportedtotrueand drop the note.Testing
scripts/sync-schema.sh --checkclean;go build/vet/test ./...green. FixesTestRegistryCoversSchemaCategories, which a bare schema sync would otherwise break.Closes#162
🤖 Generated with Claude Code
Note
Low Risk
Mostly schema vendoring and registry metadata; no new push staging paths or runtime
content_hashlogic in this diff.Overview
Fixes schema drift by updating the vendored
ingest.v1.jsonto match upstream data-ingestors: new categoriessentence_pair_classificationandembeddings, acontent_hashoption fordata_id.strategy, and expandedtexts/ validation rules (supervised sentence-pair requireslabel;embeddingsis self-supervised and must not setlabel).The CLI
categoryRegistrygains both categories asFamilyTextwithCLISupported: falseandUnsupportedNotetext (same pattern as CLM/seq2seq), so schema-valid categories are recognized instead of rejected while ingest discover/build for theirtexts/layouts remains pending.category_registry_test.gopins the expanded known set and unsupported list soTestRegistryCoversSchemaCategoriesstays green.Reviewed by Cursor Bugbot for commit d7574c9. Bugbot is set up for automated code reviews on this repo. Configure here.