Skip to content

feat(cli): sync ingest schema; wire sentence_pair_classification + embeddings - #163

Merged
saadqbal merged 1 commit into
developfrom
feat/sync-schema-embeddings-sentence-pair
Jul 7, 2026
Merged

feat(cli): sync ingest schema; wire sentence_pair_classification + embeddings#163
saadqbal merged 1 commit into
developfrom
feat/sync-schema-embeddings-sentence-pair

Conversation

@saadqbal

@saadqbalsaadqbal commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

Clears the failing Schema drift check that's red on every open PR (including #160). internal/schema/ingest.v1.json had drifted from upstream tracebloc/data-ingestors@master, which added two task categories (sentence_pair_classification, embeddings), a content_hashdata_id strategy, and description updates. The drift predates and is unrelated to any in-flight feature — it was stale on develop too.

What's in

  • Re-vendor the current upstream schema via scripts/sync-schema.sh.
  • Wire both new categories into categoryRegistry (internal/push/category.go) as FamilyText — both stage raw .txt from texts/, matching data-ingestors conventions.pyTEXT_CATEGORIES.
  • Mark both CLISupported: false with an UnsupportedNote, mirroring how causal_language_modeling / seq2seq / token_classification were added — conservative until the tracebloc ingest discover/build staging path for them is confirmed.
  • Update the pinned lists in category_registry_test.go.

⚠️ Reviewer decision

I defaulted both to not-yet-CLI-supported. If dataset push already stages the text_a\ttext_b (sentence-pair) and anchor\tpositive[\tnegative] (embeddings) texts/ layouts, flip CLISupported to true and drop the note.

Testing

scripts/sync-schema.sh --check clean; go build/vet/test ./... green. Fixes TestRegistryCoversSchemaCategories, which a bare schema sync would otherwise break.

Closes#162

🤖 Generated with Claude Code


Note

Low Risk
Mostly schema vendoring and registry metadata; no new push staging paths or runtime content_hash logic in this diff.

Overview
Fixes schema drift by updating the vendored ingest.v1.json to match upstream data-ingestors: new categories sentence_pair_classification and embeddings, a content_hash option for data_id.strategy, and expanded texts / validation rules (supervised sentence-pair requires label; embeddings is self-supervised and must not set label).

The CLI categoryRegistry gains both categories as FamilyText with CLISupported: false and UnsupportedNote text (same pattern as CLM/seq2seq), so schema-valid categories are recognized instead of rejected while ingest discover/build for their texts/ layouts remains pending. category_registry_test.go pins the expanded known set and unsupported list so TestRegistryCoversSchemaCategories stays green.

Reviewed by Cursor Bugbot for commit d7574c9. Bugbot is set up for automated code reviews on this repo. Configure here.

…beddings (#162)
The Schema drift check (scripts/sync-schema.sh --check) was red on every
open PR: internal/schema/ingest.v1.json had drifted from upstream
tracebloc/data-ingestors@master, which added two task categories
(sentence_pair_classification, embeddings), a content_hash data_id
strategy, and description updates.
- Re-vendor the current upstream schema (sync-schema.sh).
- Add both new categories to categoryRegistry as FamilyText (they stage
raw .txt from texts/, per data-ingestors conventions.py TEXT_CATEGORIES).
- Mark both CLISupported: false with an UnsupportedNote, mirroring
causal_language_modeling/seq2seq/token_classification, until the
`tracebloc ingest` discover/build staging path for them is confirmed.
(Flip to true if the push path already supports them.)
- Update the pinned lists in category_registry_test.go.
Fixes the registry⇄schema parity test (TestRegistryCoversSchemaCategories)
that a bare schema sync would otherwise break. go build/vet/test green.
Closes#162
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@saadqbal
saadqbal merged commit c0344bb into developJul 7, 2026
20 checks passed
@saadqbal
saadqbal deleted the feat/sync-schema-embeddings-sentence-pair branch July 10, 2026 10:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@saadqbal@aptracebloc@LukasWodka