Uh oh!
There was an error while loading. Please reload this page.
test(home): cover the probe unit helpers (jobsManagerReady, machineCapacity, realSignIn, realRememberedClient) - #252
Merged
Conversation
…apacity, realSignIn, realRememberedClient More of the coverage-audit "free batch" (existing fakes/config fixtures, no production changes): - jobsManagerReady (0%): prefixed + ready, zero-replicas, unprefixed legacy fallback, absent, nil-release. - machineCapacity (0%): Ready node -> compute; node-list error -> ok=false. - realSignIn (60%): the signed-in success return (email + first name). - realRememberedClient (0%): provisioned keys on the cached namespace; the display name falls back to the client ID. make ci green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
LukasWodka
commented
Jul 14, 2026
ContributorAuthor
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b931269. Configure here.
saadqbal
approved these changes
Jul 14, 2026
saadqbal
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 👍 All four probe helpers check out — the jobsManagerReady prefixed/legacy/nil-release fallback and the namespace-gates-provisioned + name→ID fallback in realRememberedClient are the fiddly ones and they're pinned correctly.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More of the coverage-audit "free batch" — existing fakes/config fixtures, no production changes.
jobsManagerReady(0%): prefixed+ready, zero-replicas, unprefixed legacy fallback, absent, nil-release.machineCapacity(0%): Ready node → compute; node-list error → ok=false.realSignIn(60%): the signed-in success return (email + first name).realRememberedClient(0%): provisioned keys on the cached namespace; display name falls back to the client ID.make cigreen.🤖 Generated with Claude Code
Note
Low Risk
Test-only additions with no runtime or production behavior changes.
Overview
Adds
internal/cli/home_probe_helpers_test.gowith unit tests for home-screen probe helpers inhome.go, using fake Kubernetes clientsets and isolated config dirs viaTRACEBLOC_CONFIG_DIR. No production code changes.jobsManagerReady— prefixed deployment with ready replicas, zero replicas, legacy unprefixedjobs-manager, missing deployment, and nil release still checking the unprefixed name.machineCapacity— a Ready node yields compute withok=true; a failed node list returnsok=false.realSignIn— empty config is not signed in; a saved profile with token returns email and first name.realRememberedClient— provisioned whenActiveClientNamespaceis set; display name fromActiveClientNameor fallback toActiveClientID; no namespace means not provisioned.Reviewed by Cursor Bugbot for commit b931269. Bugbot is set up for automated code reviews on this repo. Configure here.