Uh oh!
There was an error while loading. Please reload this page.
test(doctor,resources): cover httpProbe + the nodeLarger memory tie-break - #253
Merged
Conversation
…reak Coverage-audit "free batch", no production changes: - doctor.httpProbe (P0, was 0%): the real proxy-aware connectivity prober the CLI ships — the checks inject Options.HTTPProbe in tests, so it was never exercised. Reachable (any status) -> nil; closed host -> error; unbuildable URL -> error. - resources.nodeLarger (P1, was 67%): the equal-CPU memory tie-break no test exercised, so LargestReadyNode determinism on equal-CPU nodes was unverified. make ci green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
LukasWodka
commented
Jul 14, 2026
ContributorAuthor
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2a8cddc. Configure here.
saadqbal
approved these changes
Jul 14, 2026
saadqbal
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 👍 httpProbe (any status = reachable, dial/build failures = error) and the equal-CPU→memory tie-break in nodeLarger both match. Nice to have the real prober covered rather than just the injected one.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage-audit "free batch", no production changes.
doctor.httpProbe(P0, was 0%): the real proxy-aware connectivity prober the CLI ships — tests injectOptions.HTTPProbe, so the prober itself was never exercised. Reachable (any status) → nil; closed host → error; unbuildable URL → error.resources.nodeLarger(P1, was 67%): the equal-CPU memory tie-break no test exercised, soLargestReadyNodedeterminism on equal-CPU nodes was unverified.make cigreen.🤖 Generated with Claude Code
Note
Low Risk
Tests only; production paths are unchanged.
Overview
Adds test-only coverage for two previously under-tested helpers; no production code changes.
doctor.httpProbe: New tests call the real default connectivity prober (not injectedOptions.HTTPProbemocks). They assert any HTTP response counts as reachable, a closed host returns an error, and an invalid URL fails at request build.resources.nodeLarger: New table tests pin the equal-CPU memory tie-break used byLargestReadyNode, including cases where CPU alone would disagree with memory.Reviewed by Cursor Bugbot for commit 2a8cddc. Bugbot is set up for automated code reviews on this repo. Configure here.