ci: flip deadcode gate to blocking; delete the 3 dead #127 leftovers

[LukasWodka]

Summary

WS-A.4 of epic tracebloc/backend#1106: the deadcode gate goes blocking, the three dead #127 leftovers are deleted, and the four legit findings get an explicit, reasoned allowlist.

Key mechanism note: x/tools/cmd/deadcodealways exits 0, even with findings — so the old advisory step could never have been flipped by just removing continue-on-error. The gate now runs scripts/deadcode-check.sh, which normalizes findings to <file>: <func> (line numbers stripped so ordinary edits don't red the gate), subtracts scripts/deadcode-allowlist.txt, and fails on anything left. Stale allowlist entries warn without failing. Both loops use it: build.yml's deadcode step (continue-on-error removed) and make deadcode (|| true removed); the pin stays v0.48.0, overridable via DEADCODE_VERSION.

Deleted (each re-verified dead with the pinned deadcode@v0.48.0 before deletion)

Func	Disposition
config.clearAll	Deleted + its 3 dedicated tests (TestClearAll, TestClearAll_HomeError, TestClear) — logout uses Save; nothing production ever called it
push.allCategoryIDs	Deleted from category.go; moved verbatim into category_registry_test.go — the registry-pinning tests (cli#74 drift guards) legitimately iterate every id, but the shipped binary shouldn't carry a test-only helper
submit.isSubmitError	Deleted from client.go (+ now-orphaned errors import); moved into client_test.go as the test-local assertion helper it always was (used by client_test + submit_test, same package)

Allowlisted (the 4 legit findings, with reasons in the file)

• Status.String, JobOutcome.String — Stringers reached only via fmt's reflection dispatch, invisible to static reachability
• ReadLabelValues, inferColumnType — di#349 test-only parity harnesses that must live in production source

Stacking note

Stacked on #304 (goimports/Dependabot, WS-A.3), which stacks on #302 (staticcheck, WS-A.2) — merge order #302 → #304 → this; each then shows only its own diff. Shared-file edits (build.yml lint job, Makefile) are surgical — expected trivial rebase vs sibling PRs touching these files, merge order flexible.

Test plan (ran locally on this branch)

• ./scripts/deadcode-check.sh — clean (4 allowlisted); negative path verified: removing an allowlist entry makes it exit 1 naming the finding
• make deadcode (blocking path through the Makefile) — green
• go build ./...; go test -race ./internal/config/... ./internal/push/... ./internal/submit/... — green
• scripts/coverage-floor.sh still clears after the test deletions (cli 82.9% ≥ 68, submit 80.3% ≥ 72)
• staticcheck (all,-ST1005) still clean; make fmt-check (gofmt + goimports) green; build.yml YAML-parses; shellcheck clean on the new script
• Not run locally: full 8-platform matrix, installer harness, e2e — CI covers these

Fixes#281

🤖 Generated with Claude Code

---

Note

Low Risk
Changes are CI/tooling and removal of unused code with no production callers; behavior of login/config and submit paths is unchanged.

Overview
Deadcode goes blocking in CI (build.yml) and make deadcode: advisory continue-on-error / || true is removed in favor of scripts/deadcode-check.sh, which parses deadcode output (the tool always exits 0), subtracts scripts/deadcode-allowlist.txt, and fails on any other unreachable-from-./cmd/tracebloc symbol. Four known false positives (Stringers + di#349 parity helpers) stay allowlisted with documented reasons; stale allowlist entries only warn.

Production dead code cleanup (#127):config.clearAll and its dedicated tests are deleted (logout uses Save). push.allCategoryIDs and submit.isSubmitError move into their package test files so the binary no longer ships test-only helpers.

^{Reviewed by Cursor Bugbot for commit c556c9c. Bugbot is set up for automated code reviews on this repo. Configure here.}

[LukasWodka]

👋 Heads-up — Code review queue is at 55 / 30

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

• averaging-service#181 — feat(weights): normalize-on-read — mixed cycles average instead of rejecting (SEC-03 §8 step 2) · author: @shujaatTracebloc · no reviewer assigned
• averaging-service#182 — feat(weights): averaging writes SafeTensors (TF + PyTorch) — SEC-03 §8 step 4 · author: @shujaatTracebloc · no reviewer assigned
• backend#1079 — feat(global_meta): edge dataset_meta exposure + attributes contract at ingest (#924 G4a) · author: @divyasinghds · no reviewer assigned
• backend#1086 — docs(rfc): SafeTensors weight-format migration — SEC-03 Phase 1 (RFC 0004) · author: @shujaatTracebloc · no reviewer assigned
• backend#1093 — chore(deps): bump django from 5.2.14 to 5.2.15 · author: @dependabot · no reviewer assigned
• backend#1095 — feat(experiment): configurable preprocessing knobs incl. tabular scaler — RFC 0003 L1 + L1b (#1094) · author: @LukasWodka · no reviewer assigned
• backend#1100 — fix(boot): pin SDK install to tracebloc==0.11.2, drop 404 dev line (#1098) · author: @LukasWodka · reviewer: @saqlainsyed007
• backend#1105 — perf(api): query micro-fixes — notifications N+1, cached data_scientist, composite index, sampling (#975) · author: @aptracebloc · no reviewer assigned
• backend#1107 — perf(experiments): prefetch ExperimentListSerializer relations + cache carbon intensity (#977) · author: @aptracebloc · reviewer: @saadqbal
• backend#1108 — test(api): CLI response-shape contract fixtures for the 9 CLI endpoints (WS-D.2) · author: @LukasWodka · reviewer: @saadqbal

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

[LukasWodka]

@BugBot run

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit cb40e76. Configure here.}

[saadqbal]

👍 Verified the 3 deletions are entrypoint-unreachable (test-only refs, rewired here) — and confirmed clearAll was genuinely orphaned: logout clears via its own path (profile clear + Save prune), not clearAll. All builds + Test green. The blocking gate design (strip line:col, subtract allowlist, stale entries warn-not-fail) is solid. (Stacked on #304.)

[saadqbal]

Status: approved, stacked on #304 (ci/280-goimports-dependabot). Lands after #302→#304. Nothing needed here yet.