Uh oh!
There was an error while loading. Please reload this page.
Conversation
…ns; govulncheck CI gate (#278) * fix(deps): toolchain go1.26.5 + x/net v0.57.0 — clear 6 reachable vulns govulncheck reported 6 reachable vulnerabilities in the shipped CLI: 4 stdlib (GO-2026-5856 crypto/tls, fixed go1.26.5; GO-2026-5039 net/textproto, GO-2026-5038 mime, GO-2026-5037 crypto/x509, all fixed go1.26.4) plus 2 in golang.org/x/net v0.49.0 (GO-2026-4918 HTTP/2 infinite loop, fixed v0.53.0; GO-2026-5026 idna, fixed v0.55.0) — reachable via api.userAgentTransport.RoundTrip, submit.HTTPSubmitter.Submit, and push.CheckCSVEncoding among others. go.mod had no toolchain directive, so v0.8.0 release binaries carried whatever stdlib the runner's Go resolved to. Pin toolchain go1.26.5 (latest 1.26.x patch, verified against go.dev/dl) and bump x/net to v0.57.0 (latest stable; fix floor was v0.55.0). Only x/net and its sibling x/{sys,term,text} modules move — no k8s.io drift. After: govulncheck ./... is clean; build, vet, -race suite, and lint all green under the pinned toolchain. Part of tracebloc/backend#1106 (WS-A). See #276. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci: govulncheck gate on PRs + weekly cron sweep of develop Two copies of one pinned job (govulncheck@v1.1.4, setup-go with go-version-file: go.mod so the module toolchain governs): - build.yml: blocking job on every PR and push to develop/main — stops new code from introducing a reachable vuln. - vulncheck.yml (new): weekly cron (Mon 05:30 UTC) + workflow_dispatch, checkout pinned to develop — a CVE published against code we already ship reddens develop within a week instead of waiting for the next PR. Cron activates once this file rides the normal develop -> main promotion (scheduled workflows fire from the default branch only). Makefile grows a matching pinned `vulncheck` target, wired into `make ci` to keep the "make ci green => CI green" invariant. Part of tracebloc/backend#1106 (WS-A). See #276. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
LukasWodka
commented
Jul 14, 2026
Contributor
👋 Heads-up — Code review queue is at 55 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
LukasWodka
approved these changes
Jul 14, 2026
Uh oh!
There was an error while loading. Please reload this page.
saadqbal added a commit
that referenced
this pull request
Jul 14, 2026
…op-319 chore: back-merge main → develop after #319 promote
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ns; govulncheck CI gate (#278)
govulncheck reported 6 reachable vulnerabilities in the shipped CLI: 4 stdlib (GO-2026-5856 crypto/tls, fixed go1.26.5; GO-2026-5039 net/textproto, GO-2026-5038 mime, GO-2026-5037 crypto/x509, all fixed go1.26.4) plus 2 in golang.org/x/net v0.49.0 (GO-2026-4918 HTTP/2 infinite loop, fixed v0.53.0; GO-2026-5026 idna, fixed v0.55.0) — reachable via api.userAgentTransport.RoundTrip,
submit.HTTPSubmitter.Submit, and push.CheckCSVEncoding among others.
go.mod had no toolchain directive, so v0.8.0 release binaries carried whatever stdlib the runner's Go resolved to. Pin toolchain go1.26.5 (latest 1.26.x patch, verified against go.dev/dl) and bump x/net to v0.57.0 (latest stable; fix floor was v0.55.0). Only x/net and its sibling x/{sys,term,text} modules move — no k8s.io drift.
After: govulncheck ./... is clean; build, vet, -race suite, and lint all green under the pinned toolchain.
Part of tracebloc/backend#1106 (WS-A). See #276.
Two copies of one pinned job (govulncheck@v1.1.4, setup-go with go-version-file: go.mod so the module toolchain governs):
Makefile grows a matching pinned
vulnchecktarget, wired intomake cito keep the "make ci green => CI green" invariant.Part of tracebloc/backend#1106 (WS-A). See #276.
Note
Medium Risk
Touches release toolchain and dependency versions that affect shipped binaries, but changes are security remediation with automated reachability gates rather than application logic refactors.
Overview
Addresses six reachable CVEs that previously shipped in the customer-installed CLI by pinning
toolchain go1.26.5ingo.mod(stdlib fixes) and bumpinggolang.org/x/netand relatedx/{sys,term,text}modules;go.sumfollows.Adds blocking
govulncheckon every PR/push via a new job inbuild.yml, a weeklyvulncheck.ymlworkflow (Monday cron +workflow_dispatch, checkout ondevelop), and a pinnedmake vulnchecktarget included inmake ciso local and CI stay aligned (GOVULNCHECK_VERSION/govulncheck@v1.1.4).Reviewed by Cursor Bugbot for commit 078cca2. Bugbot is set up for automated code reviews on this repo. Configure here.