Uh oh!
There was an error while loading. Please reload this page.
fix(install.ps1): anchor cosign identity to version tags (parity with #415) - #422
Conversation
…415) install.sh rejects signatures from non-tag workflow runs; install.ps1 still accepted @.* -- Windows trusted what Unix refused. Same anchor now: refs/tags/v.* (covers rc tags too). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
LukasWodka
commented
Jul 29, 2026
👋 Heads-up — Code review queue is at 44 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
ec1b8f2 to
f4c5640Compare
shujaatTracebloc
left a comment
There was a problem hiding this comment.
LGTM — verified.
Correctness: The one-line change makes install.ps1 an exact mirror of install.sh:364 — both now use release.yml@refs/tags/v.*. This closes the platform gap where Windows accepted cosign signatures from the release.yml workflow running on any ref (branches, arbitrary tags), which Unix already rejected.
Staging tags:refs/tags/v.* correctly matches v*-rc.N staging tags (e.g. refs/tags/v1.2.3-rc.1), so promotion/staging installs keep working.
Scope:install.ps1 has exactly one --certificate-identity-regexp; no other unanchored @.* patterns remain.
CI: all checks green (e2e jobs correctly skipped — no e2e-relevant changes), Cursor Bugbot clean, no unresolved review threads.
Uh oh!
There was an error while loading. Please reload this page.
LukasWodka
commented
Jul 29, 2026
/fr-pass |
Bugbot on promotion PR #419, confirmed real: #415 anchored install.sh's cosign identity to
@refs/tags/v.*(and release.yml's verification doc with it) but install.ps1 still accepted@.*— Windows trusted signatures from non-tag workflow runs that Unix correctly rejects. This applies the same anchor to install.ps1 (coversv*-rc.Nstaging tags identically).🤖 Generated with Claude Code
Note
Low Risk
Single-line installer hardening that narrows accepted cosign identities; no runtime or auth changes.
Overview
Aligns Windows cosign verification in
install.ps1with the stricter policy already used ininstall.sh.The
--certificate-identity-regexpforrelease.ymlis tightened from@.*to@refs/tags/v.*, so signatures are only accepted when the workflow identity is tied to a version tag (includingv*-rc.Nstaging tags), not arbitrary workflow refs.Reviewed by Cursor Bugbot for commit f4c5640. Bugbot is set up for automated code reviews on this repo. Configure here.