Uh oh!
There was an error while loading. Please reload this page.
Conversation
…ppVersion to 1.24.12, add resource monitor DaemonSet and associated RBAC configurations, and enhance .gitignore to include additional values.yaml patterns.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…ppVersion to 1.24.12, modify creation timestamps and digests in index.yaml, and enhance RBAC roles to include additional resources for better access control.
| - name: host-sys | ||
| hostPath: | ||
| path: /sys | ||
| type: Directory |
There was a problem hiding this comment.
Bug: DaemonSet deploys without conditional RBAC resources
The resource-monitor-daemonset.yaml is deployed unconditionally, but it references serviceAccountName: tracebloc-resource-monitor which is only created inside the {{- if .Values.clusterRole.create }} block in rbac-rols.yaml. When .Values.clusterRole.create is false, the DaemonSet will attempt to use a non-existent ServiceAccount, causing pod creation failures. The DaemonSet needs to be wrapped in the same conditional or use a separate toggle.
Additional Locations (2)
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Updated Helm chart versions from 1.0.1 to 1.0.2 for all three environments (aks, bm, eks)
• Added Resource Monitor DaemonSet - New monitoring component deployed across all environments
• Enhanced RBAC configurations for resource monitoring capabilities
Note
Adds cluster-wide resource monitor DaemonSet with supporting RBAC across
aks,bm, andeks, bumps charts to 1.0.2 (app 1.24.12), and updates docs/index.1.0.2andappVersionto1.24.12inaks/Chart.yaml,bm/Chart.yaml,eks/Chart.yaml.index.yamlwith new package entries.templates/resource-monitor-daemonset.yamlinaks/,bm/,eks/definingDaemonSettracebloc-resource-monitor(tolerations for all nodes, host/procand/sysmounts, env vars, image pull secrets, resource limits).templates/rbac-rols.yaml: broadenClusterRoleresources (incl.pods/log,nodes,nodes/status,namespaces) and addServiceAccount,ClusterRole,ClusterRoleBindingfortracebloc-resource-monitor.README.md.Written by Cursor Bugbot for commit c644c48. This will update automatically on new commits. Configure here.