Uh oh!
There was an error while loading. Please reload this page.
Sync develop → main for v1.4.2 chart release - #169
Merged
Conversation
Brings the bugbot-followup commits from #162 back to develop: - edd22f2: rollout-status check in no-op branch + chart default tag prod → 0.3 - 15bc136: INGESTOR_TAG runtime fallback prod → 0.3 These landed on the sync branch directly during release prep to avoid an extra develop-PR cycle. Re-applying them here so develop stays current.
Sync main → develop after v1.4.1 release
LukasWodka
commented
Jun 1, 2026
Contributor
👋 Heads-up — Code review queue is at 13 / 8 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
aptracebloc
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the
developwork tomainahead of cutting the v1.4.2 release tag. Single user-facing change: PR #167 — installer survives corporate HTTP/HTTPS proxies + sanitizes credential input.Other commits in the range are the post-v1.4.1 main→develop sync (#163 / 80d2f37) — main's own state mirrored back, no net additions to main from those.
What's included
fix(#166, #168): installer survives corporate proxy + sanitizes credential input. Two issues, ten commits:scripts/lib/cluster.sh: pin k3d API to127.0.0.1:6550; propagateHTTP_PROXY/HTTPS_PROXY/NO_PROXY(with@-in-value skip + dedicated re-run warning); defensive kubeconfig0.0.0.0 → 127.0.0.1normalization (handles colon-separatedKUBECONFIG); replace misleading "Check Docker" error with a three-cause diagnostic. New_check_existing_cluster_proxywarns on per-var drift when host proxy env doesn't match an existing cluster's baked-in env._sanitize_credential+_strip_paste_garbageinscripts/lib/install-client-helm.sh. Strips ANSI CSI sequences (bracketed paste, arrow keys, cursor moves, function keys) plus C0 controls + DEL fromclientId/clientPassword._extract_yaml_valuestrips too so previously-corrupted values.yaml self-heals. UTF-8 preserved.developtohelm-ci.yamlbranches filter so chart-touching PRs to develop actually run Lint / Template / Schema / Unit checks instead of getting stuck in "Expected — Waiting".Closes #166 and #168 on merge (main is the default branch).
Chart version
client/Chart.yamlalready bumped to1.4.2in #167.Dev verification
End-to-end smoke test on customer-side EC2 by @saadqbal:
127.0.0.1kubeconfig URL. No more0.0.0.0issue. (Full corporate-proxy test still to be run by the a customer install — out-of-band.)rypveP-sumwac-5siqranow writes clean even whenread -r -scaptures a strayESC[Cfrom an arrow-key press during the prompt. Eight unit tests pass locally.Ten rounds of bugbot review on #167; all findings addressed, all threads resolved.
Skip FR gate
Adding
skip-fr-gatelabel preemptively — same pattern as #162. Kanban automation has already advanced this card toProdbecause it's release-prep, which trips the FR gate's meta-check. Same audit-logged escape hatch.After merging
v1.4.2frommainHEAD —release-helm-chart.yamlfires onrelease: types: [published]and packages/publishes the chart.main → develop(mirror of Sync main → develop after v1.4.1 release #163's pattern).🤖 Generated with Claude Code
Note
Medium Risk
Changes affect on-prem install paths (k3d/kubeconfig/proxy env and how client credentials are written to values.yaml); misconfiguration could block installs or alter stored secrets, but runtime chart auth logic is unchanged.
Overview
Syncs develop into main for the v1.4.2 Helm release (
client/Chart.yaml1.4.1 → 1.4.2).The installer is hardened for corporate HTTP/HTTPS proxies in
cluster.sh: k3d API is bound to127.0.0.1:6550, hostHTTP_PROXY/HTTPS_PROXY/NO_PROXY(and lowercase variants) are passed into new clusters when safe,@in proxy URLs is skipped with guidance, and re-runs on existing clusters get_check_existing_cluster_proxydrift warnings. kubeconfig server URLshttps://0.0.0.0:→https://127.0.0.1:are normalized (first file in colon-separatedKUBECONFIG), and API wait failures now surface proxy/Docker/kubeconfig diagnostics instead of a generic Docker message.Credential prompts in
install-client-helm.shstrip ANSI/paste/C0 garbage via_sanitize_credential/_strip_paste_garbage;_extract_yaml_valueapplies the same cleanup so corrupted saved values self-heal.Helm CI now runs on pushes/PRs targeting
developas well asmainandopenshiftwhen chart paths change.Reviewed by Cursor Bugbot for commit b6b077b. Bugbot is set up for automated code reviews on this repo. Configure here.