Skip to content

Refactor Helm chart release workflow to improve packaging and commit logic#21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saadqbal merged 1 commit into from
Mar 4, 2026
Merged

Refactor Helm chart release workflow to improve packaging and commit logic #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/release-helm-chart.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ jobs:
id: package
run: |
helm package ./tracebloc
TGZ=$(ls tracebloc-*.tgz)
TGZ=$(ls -t tracebloc-*.tgz | head -1)
echo "chart_tgz=$TGZ" >> $GITHUB_OUTPUT
echo "Packaged $TGZ"

Expand DownExpand Up@@ -78,18 +78,17 @@ jobs:
env:
REPO_URL: https://${{ github.repository_owner }}.github.io/${{ github.event.repository.name }}
run: |
CHART_TGZ=$(ls tracebloc-*.tgz)
if [ "${{ steps.fetch.outputs.index_exists }}" = "true" ] && [ -f index.yaml ]; then
helm repo index . --url "$REPO_URL" --merge index.yaml
else
helm repo index . --url "$REPO_URL"
fi
git add index.yaml "$CHART_TGZ"
git add index.yaml tracebloc-*.tgz
git status
if git diff --staged --quiet; then
echo "No index/tgz changes to commit"
else
git commit -m "Release $CHART_TGZ"
git commit -m "Release helm chart(s): $(ls tracebloc-*.tgz 2>/dev/null | tr '\n' ' ')"

@cursorcursorBotMar 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message lists all historical charts, not just new

Low Severity

The ls tracebloc-*.tgz in the commit message runs on the gh-pages branch, which accumulates .tgz files from all previous releases. As releases build up, this commit message will list every historical chart file (e.g., "Release helm chart(s): tracebloc-1.0.0.tgz tracebloc-2.0.0.tgz tracebloc-2.0.1.tgz") rather than just the newly released one. The tr '\n' ' ' flattening makes this worse than the old code, where newlines caused git to split the message so only the first filename appeared in the commit subject. The message grows unboundedly with each release.

Fix in CursorFix in Web

git push origin gh-pages
fi

Expand Down