Uh oh!
There was an error while loading. Please reload this page.
test(charts): add helm-unittest suite for jobs-manager-service template - #216
Merged
Conversation
Covers the previously-untested templates/jobs-manager-service.yaml: asserts it renders a single ClusterIP Service named jobs-manager (the stable in-cluster name contract relied on by the ingestor subchart post-install hook), is NOT a NodePort/LoadBalancer (no external exposure), selects app=manager, exposes HTTP port 8080/TCP only, and carries the standard chart labels in the release namespace. Tests-only; security invariants unchanged. Refs #193 Co-Authored-By: Claude <noreply@anthropic.com>
LukasWodka
commented
Jun 6, 2026
Contributor
👋 Heads-up — Code review queue is at 23 / 8 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
This was referenced Jun 6, 2026
aptracebloc
self-requested a review
June 8, 2026 07:41
aptracebloc
approved these changes
Jun 8, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a helm-unittest suite for the previously-untested
templates/jobs-manager-service.yaml.Tracking epic: #193
Why
jobs-manager-service.yamlexposes jobs-manager's internal HTTP ingestion endpoint at a stable in-cluster name (jobs-manager) so the ingestor subchart's post-install hook can POST without discovering Pod IPs. It had no test suite, so its ClusterIP-only boundary and name/port contract were unverified.Coverage delta
jobs-manager-service); 8 tests / ~14 assertionshelm unittest ./client)Assertions
Servicejobs-manager(stable in-cluster name contract)type: ClusterIPand notNodePort/LoadBalancer(no external exposure)app=manager8080/TCP only (single port)app=manager+ standard chart labels, in the release namespacetests-only; security invariants unchanged.
Note
Low Risk
Test-only addition with no changes to Helm templates or deployed manifests.
Overview
Adds helm-unittest coverage for
templates/jobs-manager-service.yaml, which previously had no suite.The new
client/tests/jobs_manager_service_test.yamlsuite (8 tests) locks in the rendered Service contract: fixed namejobs-manager,ClusterIPonly (explicitly not NodePort/LoadBalancer), selectorapp=manager, a single TCP 8080 HTTP port, standard chart labels plusapp=manager, and placement in the release namespace. Tests-only; no chart template or runtime behavior changes.Reviewed by Cursor Bugbot for commit 7af855a. Bugbot is set up for automated code reviews on this repo. Configure here.