Skip to content

test(charts): add helm-unittest suite for jobs-manager-service template - #216

Merged
saadqbal merged 1 commit into
developfrom
auto-coverage/jobs-manager-service
Jun 8, 2026
Merged

test(charts): add helm-unittest suite for jobs-manager-service template#216
saadqbal merged 1 commit into
developfrom
auto-coverage/jobs-manager-service

Conversation

@saadqbal

@saadqbalsaadqbal commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

What

Adds a helm-unittest suite for the previously-untested templates/jobs-manager-service.yaml.

Tracking epic: #193

Why

jobs-manager-service.yaml exposes jobs-manager's internal HTTP ingestion endpoint at a stable in-cluster name (jobs-manager) so the ingestor subchart's post-install hook can POST without discovering Pod IPs. It had no test suite, so its ClusterIP-only boundary and name/port contract were unverified.

Coverage delta

  • +1 template suite (jobs-manager-service); 8 tests / ~14 assertions
  • Chart suites 15 → 16 (167 tests total, all green via helm unittest ./client)

Assertions

  • Renders a single Service
  • Named jobs-manager (stable in-cluster name contract)
  • type: ClusterIP and notNodePort/LoadBalancer (no external exposure)
  • Selects app=manager
  • Exposes HTTP port 8080/TCP only (single port)
  • Carries app=manager + standard chart labels, in the release namespace

tests-only; security invariants unchanged.


Note

Low Risk
Test-only addition with no changes to Helm templates or deployed manifests.

Overview
Adds helm-unittest coverage for templates/jobs-manager-service.yaml, which previously had no suite.

The new client/tests/jobs_manager_service_test.yaml suite (8 tests) locks in the rendered Service contract: fixed name jobs-manager, ClusterIP only (explicitly not NodePort/LoadBalancer), selector app=manager, a single TCP 8080 HTTP port, standard chart labels plus app=manager, and placement in the release namespace. Tests-only; no chart template or runtime behavior changes.

Reviewed by Cursor Bugbot for commit 7af855a. Bugbot is set up for automated code reviews on this repo. Configure here.

Covers the previously-untested templates/jobs-manager-service.yaml:
asserts it renders a single ClusterIP Service named jobs-manager (the
stable in-cluster name contract relied on by the ingestor subchart
post-install hook), is NOT a NodePort/LoadBalancer (no external
exposure), selects app=manager, exposes HTTP port 8080/TCP only, and
carries the standard chart labels in the release namespace.
Tests-only; security invariants unchanged.
Refs #193
Co-Authored-By: Claude <noreply@anthropic.com>
@saadqbalsaadqbal added the auto-coverage Automated test-coverage PRs label Jun 6, 2026
@saadqbalsaadqbal self-assigned this Jun 6, 2026
@LukasWodka

Copy link
Copy Markdown
Contributor

👋 Heads-up — Code review queue is at 23 / 8

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

@saadqbal
saadqbal merged commit 6d381f7 into developJun 8, 2026
17 checks passed
@saadqbal
saadqbal deleted the auto-coverage/jobs-manager-service branch July 9, 2026 11:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-coverageAutomated test-coverage PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@saadqbal@LukasWodka@aptracebloc