Uh oh!
There was an error while loading. Please reload this page.
test(charts): add helm-unittest suite for requests-proxy-service template - #223
Merged
Merged
Conversation
…late Covers the previously-untested requests-proxy-service Service template: asserts ClusterIP-only (no NodePort/LoadBalancer external exposure of the egress proxy), the stable Service name, app=requests-proxy selector, the single http port 8888/TCP, standard chart labels, and release-namespace placement. Tests-only; security invariants unchanged. Refs #193 Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Jun 8, 2026
Merged
Merged
aptracebloc
self-requested a review
June 8, 2026 11:51
aptracebloc
approved these changes
Jun 8, 2026
This was referenced Jun 8, 2026
Merged
Merged
divyasinghds
approved these changes
Jun 9, 2026
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
helm-unittestsuite for the previously-untestedtemplates/requests-proxy-service.yamlService template.The
requests-proxy-servicefronts the egress requests-proxy (the component issuing stateless signed pod-proxy tokens), so its ClusterIP-only posture is a security-relevant property. This suite locks that in alongside the Service's name/selector/port contract.Coverage delta
requests-proxy-service); 8 tests / 16 assertionsrequests-proxy-servicewas the highest-priority remaining untested template (Service tier, security-relevant) —requests-proxy-deploymentwas already covered in client#194.Assertions
kind: Servicerequests-proxy-servicespec.type: ClusterIPand explicitly not NodePort / LoadBalancer (no external exposure of the egress proxy)app=requests-proxyhttpport8888/8888 TCPapp=requests-proxy+ standard chart labels (managed-by,helm.sh/chart)Verified green locally:
helm unittest -f 'tests/requests_proxy_service_test.yaml' ./client→ 8 passed.Tests-only; no source/template/values changes; security invariants unchanged.
Tracking epic: #193
Note
Low Risk
Test-only change with no runtime or chart template modifications.
Overview
Adds a helm-unittest suite for
templates/requests-proxy-service.yaml, which had no chart tests before.The eight tests pin the egress requests-proxy Service contract: one
Servicenamedrequests-proxy-service, ClusterIP only (explicitly not NodePort/LoadBalancer), selectorapp=requests-proxy, a single TCPhttpport on 8888, standard chart labels, and release-namespace placement.Tests-only; no Helm template or values changes.
Reviewed by Cursor Bugbot for commit d433cb2. Bugbot is set up for automated code reviews on this repo. Configure here.